linux-kernel - Re: [PATCH v5 2/2] dt-bindings: hwmon: Add sample averaging properties for ADM1275

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Mar 2022 10:37:38 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Potin Lai <potin.lai@...ntatw.com>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Rob Herring <robh+dt@...nel.org>
Cc:     Patrick Williams <patrick@...cx.xyz>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v5 2/2] dt-bindings: hwmon: Add sample averaging
 properties for ADM1275

On 02/03/2022 08:08, Potin Lai wrote:
> Add documentation of new properties for sample averaging in PMON_CONFIG
> register.
> 
> New properties:
> - adi,volt-curr-sample-average
> - adi,power-sample-average
> 
> Signed-off-by: Potin Lai <potin.lai@...ntatw.com>
> ---
>  .../bindings/hwmon/adi,adm1275.yaml           | 69 +++++++++++++++++++
>  1 file changed, 69 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> index 223393d7cafd..b191abddf20b 100644
> --- a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> @@ -37,6 +37,72 @@ properties:
>      description:
>        Shunt resistor value in micro-Ohm.
>  
> +  adi,volt-curr-sample-average:
> +    description: |
> +      Number of samples to be used to report voltage and current values.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [1, 2, 4, 8, 16, 32, 64, 128]
> +
> +  adi,power-sample-average:
> +    description: |
> +      Number of samples to be used to report power values.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [1, 2, 4, 8, 16, 32, 64, 128]
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - adi,adm1075
> +              - adi,adm1276
> +    then:
> +      properties:
> +        adi,volt-curr-sample-average:
> +          default: 128
> +        adi,power-sample-average-enable: false
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - adi,adm1275
> +    then:
> +      properties:
> +        adi,volt-curr-sample-average:
> +          default: 16
> +        adi,power-sample-average-enable: false
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - adi,adm1272
> +    then:
> +      properties:
> +        adi,volt-curr-sample-average:
> +          default: 128
> +        adi,power-sample-average-enable:
> +          default: 128
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - adi,adm1278
> +              - adi,adm1293
> +              - adi,adm1294
> +    then:
> +      properties:
> +        adi,volt-curr-sample-average:
> +          default: 128
> +        adi,power-sample-average-enable:

This should be adi,power-sample-average?

> +          default: 1
> +
>  required:
>    - compatible
>    - reg
> @@ -53,5 +119,8 @@ examples:
>              compatible = "adi,adm1272";
>              reg = <0x10>;
>              shunt-resistor-micro-ohms = <500>;
> +            adi,volt-curr-sample-average = <128>;
> +            adi,power-sample-average = <128>;
> +            adi,power-sample-average-enable;

This property does not exist. Did you run dt_binding_check?

>          };
>      };


Best regards,
Krzysztof