linux-kernel - Re: [PATCHv5 02/30] x86/tdx: Provide common base for SEAMCALL and TDCALL C wrappers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220310144404.5g4asrzzxwon7v7u@black.fi.intel.com>
Date:   Thu, 10 Mar 2022 17:44:04 +0300
From:   "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     tglx@...utronix.de, mingo@...hat.com, dave.hansen@...el.com,
        luto@...nel.org, peterz@...radead.org,
        sathyanarayanan.kuppuswamy@...ux.intel.com, aarcange@...hat.com,
        ak@...ux.intel.com, dan.j.williams@...el.com, david@...hat.com,
        hpa@...or.com, jgross@...e.com, jmattson@...gle.com,
        joro@...tes.org, jpoimboe@...hat.com, knsathya@...nel.org,
        pbonzini@...hat.com, sdeep@...are.com, seanjc@...gle.com,
        tony.luck@...el.com, vkuznets@...hat.com, wanpengli@...cent.com,
        thomas.lendacky@....com, brijesh.singh@....com, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv5 02/30] x86/tdx: Provide common base for SEAMCALL and
 TDCALL C wrappers

On Thu, Mar 10, 2022 at 01:32:40PM +0100, Borislav Petkov wrote:
> On Wed, Mar 02, 2022 at 05:27:38PM +0300, Kirill A. Shutemov wrote:
> >  arch/x86/include/asm/tdx.h    | 28 +++++++++++
> >  arch/x86/kernel/asm-offsets.c |  9 ++++
> >  arch/x86/virt/tdxcall.S       | 95 +++++++++++++++++++++++++++++++++++
> 
> Right, you asked already about putting this under arch/x86/virt/ but on
> a second thought, this doesn't look like
> 
> "- generic host virtualization stuff: arch/x86/virt/"
> 
> to me:
> 
> https://lore.kernel.org/r/Yg5nh1RknPRwIrb8@zn.tnic
> 
> Rather, this looks like it wants to be under
> 
>  arch/x86/virt/vmx/tdx/
> 
> where we said that this should be the coco host code place.

I'm fine moving where you want. But I want to make sure we are on the same
page: this code is common for guest and host TDX. I think VMX referes more
to host side of the thing, no?

-- 
 Kirill A. Shutemov