linux-kernel - Re: [PATCH] dt-bindings: media: mediatek,vcodec: Fix addressing cell sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 23 Mar 2022 09:05:32 -0500
From:   Rob Herring <robh@...nel.org>
To:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Yunfei Dong <yunfei.dong@...iatek.com>
Cc:     Linux Media Mailing List <linux-media@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH] dt-bindings: media: mediatek,vcodec: Fix addressing cell sizes

On Tue, Mar 1, 2022 at 5:35 PM Rob Herring <robh@...nel.org> wrote:
>
> 'dma-ranges' in the example is written for cell sizes of 2 cells, but
> the schema and example specify sizes of 1 cell. As the h/w has a bus
> address of >32-bits, cell sizes of 2 is correct. Update the schema's
> '#address-cells' and '#size-cells' to be 2 and adjust the example
> throughout.
>
> There's no error currently because dtc only checks 'dma-ranges' is a
> correct multiple number of cells (3) and the schema checking is based on
> bracketing of entries.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> I noticed the driver is checking 'dma-ranges' itself. That's generally
> wrong as the core code should be configuring bus dma masks
> automatically.
> ---
>  .../media/mediatek,vcodec-subdev-decoder.yaml | 122 +++++++++---------
>  1 file changed, 64 insertions(+), 58 deletions(-)

Can this fix be applied for rc1? Still failing in linux-next.

Rob