linux-kernel - Re: [PATCH 3/3] arm64: meson: update SDIO in dts for JetHub D1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Mar 2022 18:33:28 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Vyacheslav Bocharov <adeep@...ina.in>,
        Kevin Hilman <khilman@...libre.com>,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 3/3] arm64: meson: update SDIO in dts for JetHub D1

Hi,

On 25/03/2022 17:55, Vyacheslav Bocharov wrote:
> Fix the dts to match board's reference design:
> - update vddio_boot regulator to 3.3v (Wi-Fi SDIO module)
> - add vccq_1v8 regulator with 1.8v for eMMC SDIO
> 
> In the first revision of JetHub D1 the vccq_1v8 regulator was 3.3v.
> All installed eMMC modules were tested to work in HS200 mode at 3.3v
> supply voltage. In the next revisions of the board eMMC will be
> powered with 1.8v according to the standard.
> 
> Signed-off-by: Vyacheslav Bocharov <adeep@...ina.in>
> ---
>   .../dts/amlogic/meson-axg-jethome-jethub-j100.dts | 15 ++++++++++++---
>   1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
> index 66c1eeba8f48..bc00d672a357 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
> @@ -81,12 +81,22 @@ vddio_ao18: regulator-vddio_ao18 {
>   	vddio_boot: regulator-vddio_boot {
>   		compatible = "regulator-fixed";
>   		regulator-name = "VDDIO_BOOT";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		vin-supply = <&vddao_3v3>;
> +		regulator-always-on;
> +	};
> +
> +	vccq_1v8: regulator-vccq_1v8 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "VCCQ_1V8";
>   		regulator-min-microvolt = <1800000>;
>   		regulator-max-microvolt = <1800000>;
>   		vin-supply = <&vddao_3v3>;
>   		regulator-always-on;
>   	};
>   
> +
>   	usb_pwr: regulator-usb_pwr {
>   		compatible = "regulator-fixed";
>   		regulator-name = "USB_PWR";
> @@ -248,8 +258,7 @@ &sd_emmc_b {
>   
>   	bus-width = <4>;
>   	cap-sd-highspeed;
> -	sd-uhs-sdr104;
> -	max-frequency = <200000000>;
> +	max-frequency = <50000000>;

This changes should be in a separate commit

>   	non-removable;
>   	disable-wp;
>   
> @@ -282,7 +291,7 @@ &sd_emmc_c {
>   	mmc-pwrseq = <&emmc_pwrseq>;
>   
>   	vmmc-supply = <&vcc_3v3>;
> -	vqmmc-supply = <&vddio_boot>;
> +	vqmmc-supply = <&vccq_1v8>;
>   };
>   
>   /* UART Bluetooth */