linux-kernel - Re: [PATCH net] ipw2x00: use DEVICE_ATTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r16apm7s.fsf@kernel.org>
Date:   Wed, 06 Apr 2022 12:58:31 +0300
From:   Kalle Valo <kvalo@...nel.org>
To:     Meng Tang <tangmeng@...ontech.com>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] ipw2x00: use DEVICE_ATTR_*() macro

Meng Tang <tangmeng@...ontech.com> writes:

> Use DEVICE_ATTR_*() helper instead of plain DEVICE_ATTR,
> which makes the code a bit shorter and easier to read.
>
> Signed-off-by: Meng Tang <tangmeng@...ontech.com>
> ---
>  drivers/net/wireless/intel/ipw2x00/ipw2100.c |  64 +++++-----
>  drivers/net/wireless/intel/ipw2x00/ipw2200.c | 119 +++++++++----------
>  2 files changed, 90 insertions(+), 93 deletions(-)

You have submitted a similar (or identical?) patch earlier:

https://patchwork.kernel.org/project/linux-wireless/patch/20220401053138.17749-1-tangmeng@uniontech.com/

If you submit a new patch mark it as v2 and include a changelog. Please
read our documentation:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches