linux-kernel - Re: [PATCH V3 2/2] arm64: dts: qcom: sc7280: Add reset entries for SDCC controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <278b3ab9-a790-76f2-df6d-97b37d5e5e23@quicinc.com>
Date:   Wed, 6 Apr 2022 15:26:47 +0530
From:   "Sajida Bhanu (Temp)" <quic_c_sbhanu@...cinc.com>
To:     Stephen Boyd <swboyd@...omium.org>, <agross@...nel.org>,
        <bjorn.andersson@...aro.org>, <devicetree@...r.kernel.org>,
        <krzk+dt@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
        <robh+dt@...nel.org>, <ulf.hansson@...aro.org>
CC:     <quic_rampraka@...cinc.com>, <quic_pragalla@...cinc.com>,
        <quic_sartgarg@...cinc.com>, <quic_nitirawa@...cinc.com>,
        <quic_sayalil@...cinc.com>
Subject: Re: [PATCH V3 2/2] arm64: dts: qcom: sc7280: Add reset entries for
 SDCC controllers

Hi,

Thanks for the review.

Please find the inline comments.

Thanks,
Sajida

On 4/2/2022 3:39 AM, Stephen Boyd wrote:
> Quoting Shaik Sajida Bhanu (2022-03-17 08:49:25)
>> Add gcc hardware reset entries for eMMC and SD card.
>>
>> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@...cinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index c07765d..cd50ea3 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -881,6 +881,10 @@
>>                          mmc-hs400-1_8v;
>>                          mmc-hs400-enhanced-strobe;
>>
>> +                       /* gcc hardware reset entry for eMMC */
> Please don't add this worthless comment.
>
>> +                       resets = <&gcc GCC_SDCC1_BCR>;
>> +                       reset-names = "core_reset";
> A "_reset" postfix is redundant. In fact, reset-names shouldn't even be
> required.
Ok
>> +
>>                          sdhc1_opp_table: opp-table {
>>                                  compatible = "operating-points-v2";
>>
>> @@ -2686,6 +2690,10 @@
>>
>>                          qcom,dll-config = <0x0007642c>;
>>
>> +                       /* gcc hardware reset entry for SD card */
> Please don't add this worthless comment.
Sure will remove the comment.
>> +                       resets = <&gcc GCC_SDCC2_BCR>;
>> +                       reset-names = "core_reset";
>> +
>>                          sdhc2_opp_table: opp-table {
>>                                  compatible = "operating-points-v2";
>>