linux-kernel - Re: [PATCH] watchdog: rti-wdt: Fix pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 12 Apr 2022 07:18:43 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Miaoqian Lin <linmq006@...il.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Tero Kristo <t-kristo@...com>, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: rti-wdt: Fix pm_runtime_get_sync() error
 checking

On 4/12/22 00:08, Miaoqian Lin wrote:
> If the device is already in a runtime PM enabled state
> pm_runtime_get_sync() will return 1, so a test for negative
> value should be used to check for errors.
> 
> Fixes: 2d63908bdbfb ("watchdog: Add K3 RTI watchdog support")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/rti_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/rti_wdt.c b/drivers/watchdog/rti_wdt.c
> index db843f825860..00ebeffc674f 100644
> --- a/drivers/watchdog/rti_wdt.c
> +++ b/drivers/watchdog/rti_wdt.c
> @@ -226,7 +226,7 @@ static int rti_wdt_probe(struct platform_device *pdev)
>   
>   	pm_runtime_enable(dev);
>   	ret = pm_runtime_get_sync(dev);
> -	if (ret) {
> +	if (ret < 0) {
>   		pm_runtime_put_noidle(dev);
>   		pm_runtime_disable(&pdev->dev);
>   		return dev_err_probe(dev, ret, "runtime pm failed\n");