linux-kernel - Re: [PATCH v3] sound/oss/dmasound: fix build when drivers are mixed =y/=m

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <34f3fe4a-7d75-d007-2b22-54d44f49a435@infradead.org>
Date:   Fri, 15 Apr 2022 07:45:36 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
        kernel test robot <lkp@...el.com>,
        Arnd Bergmann <arnd@...db.de>, Takashi Iwai <tiwai@...e.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH v3] sound/oss/dmasound: fix build when drivers are mixed
 =y/=m



On 4/15/22 06:48, Guenter Roeck wrote:
> On Tue, Apr 05, 2022 at 04:41:18PM -0700, Randy Dunlap wrote:
>> When CONFIG_DMASOUND_ATARI=m and CONFIG_DMASOUND_Q40=y (or vice versa),
>> dmasound_core.o can be built without dmasound_deinit() being defined,
>> causing a build error:
>>
>> ERROR: modpost: "dmasound_deinit" [sound/oss/dmasound/dmasound_atari.ko] undefined!
>>
>> Modify dmasound_core.c and dmasound.h so that dmasound_deinit() is
>> always available.
>>
>> The mixed modes (=y/=m) also mean that several variables and structs
>> have to be declared in all cases.
>>
>> Suggested-by: Arnd Bergmann <arnd@...db.de>
>> Suggested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Link: lore.kernel.org/r/202204032138.EFT9qGEd-lkp@...el.com
>> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
>> Cc: Jaroslav Kysela <perex@...ex.cz>
>> Cc: Takashi Iwai <tiwai@...e.com>
>> Cc: alsa-devel@...a-project.org
>> ---
> 
> m68k:allmodconfig fails to build with this patch in the tree.
> 
> Error log:
> sound/oss/dmasound/dmasound_core.c:1431:12: error: 'dmasound_setup' defined but not used
> 
> ... because __setup() is empty if MODULE is defined.
> 
> Guenter

Takashi has already merged a patch for this from Miles Chen.

thanks.

-- 
~Randy