linux-kernel - Re: [PATCH v1 1/1] iio: afe: rescale: Make use of device properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YlmFezCYNeUxa8cL@shaak>
Date:   Fri, 15 Apr 2022 10:47:23 -0400
From:   Liam Beguin <liambeguin@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Peter Rosin <peda@...ntia.se>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v1 1/1] iio: afe: rescale: Make use of device properties

On Thu, Apr 14, 2022 at 08:03:59PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 14, 2022 at 10:32:38AM -0400, Liam Beguin wrote:
> > Hi Andy,
> > 
> > On Wed, Apr 13, 2022 at 10:01:17PM +0300, Andy Shevchenko wrote:
> > > Convert the module to be property provider agnostic and allow
> > > it to be used on non-OF platforms.
> 
> > > +#include <linux/mod_devicetable.h>
> > 
> > Is this really needed?
> 
> Yes.
> This header is missed. I can split its addition to a separate patch.

Understood, maybe a separate patch would make it more explicit.

Cheers,
Liam

> > device_get_match_data() is already defined in <linux/property.h>
> 
> It's indirectly related (just like we do when we clean up of.h). Since
> the original of.h is missed there is no header replacement, just adding.
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>