linux-kernel - Re: [PATCH v2] gpio: gpio-vf610: do not touch other bits when set the target bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Mf_fc9h-8TokbYapVV=mer8b3MQumO=Y9QLgjbKnNh6Cw@mail.gmail.com>
Date:   Fri, 13 May 2022 21:52:56 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     haibo.chen@....com
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Aisheng Dong <aisheng.dong@....com>,
        Peng Fan <peng.fan@....com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        NXP Linux Team <linux-imx@....com>
Subject: Re: [PATCH v2] gpio: gpio-vf610: do not touch other bits when set the
 target bit

On Wed, May 11, 2022 at 4:27 AM <haibo.chen@....com> wrote:
>
> From: Haibo Chen <haibo.chen@....com>
>
> For gpio controller contain register PDDR, when set one target bit,
> current logic will clear all other bits, this is wrong. Use operator
> '|=' to fix it.
>
> Fixes: 659d8a62311f ("gpio: vf610: add imx7ulp support")
> Reviewed-by: Peng Fan <peng.fan@....com>
> Signed-off-by: Haibo Chen <haibo.chen@....com>
> ---
>  drivers/gpio/gpio-vf610.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
> index 20780c35da1b..23cddb265a0d 100644
> --- a/drivers/gpio/gpio-vf610.c
> +++ b/drivers/gpio/gpio-vf610.c
> @@ -125,9 +125,13 @@ static int vf610_gpio_direction_output(struct gpio_chip *chip, unsigned gpio,
>  {
>         struct vf610_gpio_port *port = gpiochip_get_data(chip);
>         unsigned long mask = BIT(gpio);
> +       u32 val;
>
> -       if (port->sdata && port->sdata->have_paddr)
> -               vf610_gpio_writel(mask, port->gpio_base + GPIO_PDDR);
> +       if (port->sdata && port->sdata->have_paddr) {
> +               val = vf610_gpio_readl(port->gpio_base + GPIO_PDDR);
> +               val |= mask;
> +               vf610_gpio_writel(val, port->gpio_base + GPIO_PDDR);
> +       }
>
>         vf610_gpio_set(chip, gpio, value);
>
> --
> 2.25.1
>

Applied, thanks!

Bart