linux-kernel - Re: [PATCH] KVM: SVM: Use kzalloc for sev ioctl interfaces to prevent kernel memory leak.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yn630RFKQiiMRnnf@google.com>
Date:   Fri, 13 May 2022 19:56:01 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     Ashish Kalra <ashkalra@....com>
Cc:     Peter Gonda <pgonda@...gle.com>,
        Ashish Kalra <Ashish.Kalra@....com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, Joerg Roedel <joro@...tes.org>,
        "Lendacky, Thomas" <Thomas.Lendacky@....com>,
        Borislav Petkov <bp@...en8.de>,
        the arch/x86 maintainers <x86@...nel.org>,
        kvm list <kvm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andy Nguyen <theflow@...gle.com>,
        David Rientjes <rientjes@...gle.com>,
        John Allen <john.allen@....com>
Subject: Re: [PATCH] KVM: SVM: Use kzalloc for sev ioctl interfaces to
 prevent kernel memory leak.

On Fri, May 13, 2022, Ashish Kalra wrote:
> Hello Sean & Peter,
> > Looking through other copy_to_user() calls:
> > 
> >    - "blob" in sev_ioctl_do_pek_csr()
> >    - "id_blob" in sev_ioctl_do_get_id2()
> >    - "pdh_blob" and "cert_blob" in sev_ioctl_do_pdh_export()
> 
> These functions are part of the ccp driver and a fix for them has already
> been sent upstream to linux-crypto@...r.kernel.org and
> linux-kernel@...r.kernel.org:
> 
> [PATCH] crypto: ccp - Use kzalloc for sev ioctl interfaces to prevent kernel
> memory leak

Ha, that's why I was getting a bit of deja vu.  I saw that fly by and then got it
confused with this patch.