linux-kernel - Re: [PATCH v2 4/5] clang-format: Fix empty curly braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 May 2022 11:00:00 -0700
From:   Joe Perches <joe@...ches.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Mickaël Salaün <mic@...ikod.net>,
        Miguel Ojeda <ojeda@...nel.org>,
        Andy Whitcroft <apw@...onical.com>,
        Brian Norris <briannorris@...omium.org>,
        Dwaipayan Ray <dwaipayanray1@...il.com>,
        "Jason A . Donenfeld" <Jason@...c4.com>,
        Kees Cook <keescook@...omium.org>,
        Konstantin Meskhidze <konstantin.meskhidze@...wei.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Paul Moore <paul@...l-moore.com>, Tom Rix <trix@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>, llvm@...ts.linux.dev
Subject: Re: [PATCH v2 4/5] clang-format: Fix empty curly braces

On Fri, 2022-05-20 at 19:50 +0200, Miguel Ojeda wrote:
> Hi Joe,
> 
> On Fri, May 20, 2022 at 7:24 PM Joe Perches <joe@...ches.com> wrote:
> > 
> > static inline void foo1(...) {}
> > static inline void foo2(...) {}
> > ...
> > static inline void fooN(...) {}
> 
> Those are the non-wrapped-from-signature case, which are handled
> before this option takes place, i.e. this option is about:
> 
>     void f()
>     {}
> 
> vs.
> 
>     void f()
>     {
>     }
> 
> For putting everything on the same line, we could adjust
> `AllowShortFunctionsOnASingleLine` from `None` to `Empty`, though.

As you wish.

I think it's more that there's no "one true style" issue than anything.