linux-kernel - Re: [PATCH v2 4/5] clang-format: Fix empty curly braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=SLoKSUzbWV4r3jt31trEV2ooHH7r_pSDF_dkU4bc7fQ@mail.gmail.com>
Date:   Fri, 20 May 2022 20:57:05 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Mickaël Salaün <mic@...ikod.net>,
        Miguel Ojeda <ojeda@...nel.org>,
        Andy Whitcroft <apw@...onical.com>,
        Brian Norris <briannorris@...omium.org>,
        Dwaipayan Ray <dwaipayanray1@...il.com>,
        "Jason A . Donenfeld" <Jason@...c4.com>,
        Kees Cook <keescook@...omium.org>,
        Konstantin Meskhidze <konstantin.meskhidze@...wei.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Paul Moore <paul@...l-moore.com>, Tom Rix <trix@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>, llvm@...ts.linux.dev
Subject: Re: [PATCH v2 4/5] clang-format: Fix empty curly braces

On Fri, May 20, 2022 at 8:00 PM Joe Perches <joe@...ches.com> wrote:
>
> As you wish.
>
> I think it's more that there's no "one true style" issue than anything.

Indeed, there are many instances of both. Not sure which one we should pick.

Maybe everything in a line is less annoying in more cases for people
that want to automate formatting (and `clang-format` will wrap it if
it goes over the column limit anyway, and then it will split it in
several lines, so it is OK).

Cheers,
Miguel