linux-kernel - Re: [PATCH 0/2] bitops: _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0b25e5f-5493-d4e2-5bc4-f90d47966c38@intel.com>
Date:   Thu, 26 May 2022 12:08:57 +0200
From:   Cezary Rojewski <cezary.rojewski@...el.com>
To:     Amadeusz Sławiński 
        <amadeuszx.slawinski@...ux.intel.com>,
        Vineet Gupta <vgupta@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
CC:     <linux-snps-arc@...ts.infradead.org>,
        <linux-m68k@...ts.linux-m68k.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] bitops: __fls adjustments

On 2022-05-25 4:48 PM, Amadeusz Sławiński wrote:
> Apparently on few architectures __fls is defined incorrectly. Fix this
> by adjusting declarations to asm-generic ones.
> 
> As far as I can tell there should be no functional changes, but I don't
> have devices to test it, so it was only compile tested.
> 
> Amadeusz Sławiński (2):
>    ARC: bitops: Change __fls to return unsigned long
>    m68k: bitops: Change __fls to return and accept unsigned long
> 
>   arch/arc/include/asm/bitops.h  | 2 +-
>   arch/m68k/include/asm/bitops.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 

Thanks for the fixes Amadeo!

I wonder if there are more places like this to address..
Not tested but I do not see any issues with the code so:

Reviewed-by: Cezary Rojewski <cezary.rojewski@...el.com>


Regards,
Czarek