[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAL_JsqJqdLrhjCiQ3a1PZvfnW715HhXNMQZea2H78T4U2BqDzA@mail.gmail.com>
Date: Thu, 26 May 2022 07:46:12 -0500
From: Rob Herring <robh@...nel.org>
To: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Masami Hiramatsu <mhiramat@...nel.org>,
PCI <linux-pci@...r.kernel.org>, devicetree@...r.kernel.org,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Add missing
child interrupt controller
On Thu, May 26, 2022 at 4:02 AM Kunihiko Hayashi
<hayashi.kunihiko@...ionext.com> wrote:
>
> Hi Rob,
>
> On 2022/05/26 6:01, Rob Herring wrote:
> > The Socionext interrupt controller internal to the the PCI block isn't
> > documented which causes warnings when unevaluatedProperties check is
> > also fixed. Add the 'interrupt-controller' child node and properties and
> > fixup the example so that interrupt properties can be parsed.
>
> Surely internal interrupt controller isn't described, and should be documented.
> And the child node name "legacy-interrupt-controller" also should be fixed.
>
> Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
Thanks.
>
> BTW I can't reproduce such warnings with my environment.
> Can you show the command line to reproduce the warnings?
"causes warnings when unevaluatedProperties check is also fixed"
You won't. I have a fix in dtschema pending, but first all the
warnings that appear need to be fixed.
Rob
Powered by blists - more mailing lists