linux-kernel - Re: [PATCH v3 4/4] riscv: dts: sifive: "fix" pmic watchdog node name

Open Source and information security mailing list archives

Message-ID: <2247394.ElGaqSPkdT@diego>
Date:   Mon, 13 Jun 2022 16:05:12 +0200
From:   Heiko Stübner <heiko@...ech.de>
To:     palmer@...belt.com, palmer@...osinc.com,
        linux-riscv@...ts.infradead.org
Cc:     Conor.Dooley@...rochip.com, linux-i2c@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        lee.jones@...aro.org, robh+dt@...nel.org,
        linux-mmc@...r.kernel.org, paul.walmsley@...ive.com,
        atulkhare@...osinc.com, support.opensource@...semi.com,
        andrew@...n.ch, krzysztof.kozlowski@...aro.org,
        stwiss.opensource@...semi.com, linux-riscv@...ts.infradead.org,
        aou@...s.berkeley.edu, ulf.hansson@...aro.org,
        krzysztof.kozlowski+dt@...aro.org, Conor.Dooley@...rochip.com
Subject: Re: [PATCH v3 4/4] riscv: dts: sifive: "fix" pmic watchdog node name

Am Montag, 13. Juni 2022, 15:33:49 CEST schrieb Conor.Dooley@...rochip.com:
> 
> On 06/06/2022 21:13, Conor Dooley wrote:
> > From: Conor Dooley <conor.dooley@...rochip.com>
> > 
> > After converting the pmic watchdog binding to yaml, dtbs_check complains
> > that the node name doesn't match the binding. "Fix" it.
> 
> Hey Palmer,
> The three dt-binding changes were accepted - do I need to poke SiFive to
> ack the dts change or are you fine just taking it?

I don't think a node-name has relevance to vendor decisions ;-) .

Looking at bindings/watchdog/watchdog.yaml we clearly see that
the node name is always watchdog or watchdog@foo, so this change
is clearly correct.

Reviewed-by: Heiko Stuebner <heiko@...ech.de>

> Thanks,
> Conor.
> 
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> > ---
> >   arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > index c4ed9efdff03..1f386b07a832 100644
> > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > @@ -90,7 +90,7 @@ rtc {
> >   			compatible = "dlg,da9063-rtc";
> >   		};
> >   
> > -		wdt {
> > +		watchdog {
> >   			compatible = "dlg,da9063-watchdog";
> >   		};
> >   
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives