linux-kernel - Re: [PATCH v2] Documentation: kunit: Cleanup run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABVgOSkybS55KynNvSA-B=2Lemwe-iTOwZ55BO4PwaECokizTw@mail.gmail.com>
Date:   Wed, 29 Jun 2022 17:05:57 +0800
From:   David Gow <davidgow@...gle.com>
To:     Bagas Sanjaya <bagasdotme@...il.com>
Cc:     Daniel Latypov <dlatypov@...gle.com>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        Shuah Khan <skhan@...uxfoundation.org>,
        KUnit Development <kunit-dev@...glegroups.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH v2] Documentation: kunit: Cleanup run_wrapper, fix x-ref

On Wed, Jun 29, 2022 at 4:44 PM Bagas Sanjaya <bagasdotme@...il.com> wrote:
>
> On 6/29/22 11:06, David Gow wrote:
> > +This means that for most architectures, running under qemu is as simple as:
> > +
> > +.. code-block:: bash
> > +
> > +     ./tools/testing/kunit/kunit.py run --arch=x86_64
> > +
> > +When cross-compiling, we'll likely need to specify a different toolchain, for
> > +example:
> > +
> > +.. code-block:: bash
> > +
> > +     ./tools/testing/kunit/kunit.py run \
> > +             --arch=s390 \
> > +             --cross_compile=s390x-linux-gnu-
> > +
>
> nit: s/we'll/you'll/
>
> Otherwise looks OK.

Thanks. The rest of this document is using "we" rather than "you", so
I used "we'll" for consistency. If "you" is preferred generally, it'd
be best to change it throughout the document (probably in a separate
patch).

Cheers,
-- David

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4003 bytes)