linux-kernel - Re: [PATCH v11 09/14] module: Move kallsyms support into a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yr92YtG12f+II+ea@bombadil.infradead.org>
Date:   Fri, 1 Jul 2022 15:34:10 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Aaron Tomlin <atomlin@...hat.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>, christophe.leroy@...roup.eu,
        cl@...ux.com, mbenes@...e.cz, akpm@...ux-foundation.org,
        jeyu@...nel.org, linux-kernel@...r.kernel.org,
        linux-modules@...r.kernel.org, void@...ifault.com,
        atomlin@...mlin.com, allen.lkml@...il.com, joe@...ches.com,
        msuchanek@...e.de, oleksandr@...alenko.name,
        jason.wessel@...driver.com, pmladek@...e.com,
        daniel.thompson@...aro.org, hch@...radead.org,
        Chuck Lever III <chuck.lever@...cle.com>
Subject: Re: [PATCH v11 09/14] module: Move kallsyms support into a separate
 file

On Tue, Jun 28, 2022 at 09:19:06AM +0100, Aaron Tomlin wrote:
> On Tue 2022-06-28 00:05 -0400, Steven Rostedt wrote:
> > On Thu, 10 Mar 2022 10:24:08 +0000
> > Aaron Tomlin <atomlin@...hat.com> wrote:
> > 
> > > No functional change.
> > > 
> > 
> > And this too has a functional change as well.
> > 
> > Reported-by: Chuck Lever III <chuck.lever@...cle.com>
> > Link: https://lore.kernel.org/all/355D2478-33D3-4046-8422-E512F42C51BC@oracle.com/
> > 
> > 
> > Before this patch:
> > 
> >  # grep -a '^[0-9a-f]* [^a-zA-Z]' /proc/kallsyms
> > 
> > Nothing.
> > 
> > After this patch:
> > 
> >  # grep -a '^[0-9a-f]* [^a-zA-Z]' /proc/kallsyms
> > ffffffffc09df024 ^@ _note_9     [ebtables]
> > ffffffffc09df03c ^@ _note_8     [ebtables]
> > ffffffffc0e25024 ^@ _note_9     [bridge]
> > ffffffffc0e2503c ^@ _note_8     [bridge]
> > ffffffffc0e01000 ^@ br_switchdev_event  [bridge]
> > ffffffffc0e39548 ^@ __warned.10 [bridge]
> > ffffffffc09bd024 ^@ _note_9     [stp]
> > ffffffffc09bd03c ^@ _note_8     [stp]
> > ffffffffc0849024 ^@ _note_9     [vmw_vmci]
> > ffffffffc084903c ^@ _note_8     [vmw_vmci]
> > ffffffffc0849454 ^@ __kstrtab_vmci_context_get_priv_flags       [vmw_vmci]
> > ffffffffc0849470 ^@ __kstrtabns_vmci_context_get_priv_flags     [vmw_vmci]
> > ffffffffc0849054 ^@ __ksymtab_vmci_context_get_priv_flags       [vmw_vmci]
> > ffffffffc081d024 ^@ _note_9     [nf_reject_ipv6]
> > ffffffffc081d03c ^@ _note_8     [nf_reject_ipv6]
> > ffffffffc081d0a8 ^@ __kstrtab_nf_reject_skb_v6_tcp_reset        [nf_reject_ipv6]
> > ffffffffc081d0c3 ^@ __kstrtabns_nf_reject_skb_v6_tcp_reset      [nf_reject_ipv6]
> > ffffffffc081d078 ^@ __ksymtab_nf_reject_skb_v6_tcp_reset        [nf_reject_ipv6]
> > ffffffffc081d0c4 ^@ __kstrtab_nf_reject_skb_v6_unreach  [nf_reject_ipv6]
> > 
> > The kallsyms get corrupted output, and this breaks trace-cmd.
> 
> Hi Steve,
> 
> I will look into this straight away.

Poke, did you get to implement this yet?

  Luis