linux-kernel - Re: [PATCH v1 1/1] gpiolib: of: Use device_match_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=McZaRBKP2P8zY3GjnvrDQnCELc+sa7Zp2wt_T57-i+hPQ@mail.gmail.com>
Date:   Fri, 8 Jul 2022 16:34:24 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/1] gpiolib: of: Use device_match_of_node() helper

On Wed, Jun 29, 2022 at 1:30 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> Instead of open coding, use device_match_of_node() helper.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/gpio/gpiolib-of.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 3d6c3ffd5576..23b8de98bf7c 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -720,7 +720,7 @@ static void of_gpiochip_remove_hog(struct gpio_chip *chip,
>
>  static int of_gpiochip_match_node(struct gpio_chip *chip, void *data)
>  {
> -       return chip->gpiodev->dev.of_node == data;
> +       return device_match_of_node(&chip->gpiodev->dev, data);
>  }
>
>  static struct gpio_chip *of_find_gpiochip_by_node(struct device_node *np)
> --
> 2.35.1
>

Applied, thanks!

Bart