linux-kernel - Re: [RFC PATCH 3/3] arm64: dts: bcmbca: update bcm4808 board dts file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9bc3e0b6-833e-375e-70d6-1dbd036ef25a@broadcom.com>
Date:   Tue, 12 Jul 2022 10:48:03 -0700
From:   William Zhang <william.zhang@...adcom.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Linux ARM List <linux-arm-kernel@...ts.infradead.org>,
        Rafał Miłecki <rafal@...ecki.pl>
Cc:     kursad.oney@...adcom.com, anand.gore@...adcom.com,
        dan.beygelman@...adcom.com,
        Broadcom Kernel List <bcm-kernel-feedback-list@...adcom.com>,
        joel.peshkin@...adcom.com,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 3/3] arm64: dts: bcmbca: update bcm4808 board dts file



On 7/12/22 08:50, Krzysztof Kozlowski wrote:
> On 12/07/2022 17:36, Florian Fainelli wrote:
>> On 7/12/22 00:47, Krzysztof Kozlowski wrote:
>>> On 12/07/2022 04:11, William Zhang wrote:
>>>> Update compatible string based on the new bcmbca binding rule
>>>> for BCM4908 famliy based boards
>>>
>>> Typo - family
>>>
>>> Please explain why breaking the ABI (and users of these DTS_ is acceptable.
>>
>> This will be largely targeted towards Rafal who supports these kinds of
>> devices with an upstream kernel. My understanding is that this is OK
>> because we will always ship a DTB matching the Linux kernel, and I
>> believe this is true for both the way that William and his group support
>> these devices, as well as how OpenWrt, buildroot or other build systems
>> envision to support these devices.
Yes that is correct for bca group.

>>
>> Rafal, does that sound about right?
> 
> I am fine, just maybe mention it in the commit because it literally
> breaks the DTSes.
> 
> I assume you considered all possible uses outside of Linux like U-Boot,
> BSD etc?
> 
> Best regards,
> Krzysztof

The reason for this patch is to keep the bcmbca board dts in the same 
format and keep everything in the same yaml file. Understand 4908 was 
already upstream but luckily there is no driver in linux and u-boot that 
uses these 4908 compatible strings. They are only used in the board dts 
as far as I can see.  So it does not really break anything in the end, 
unless someone use them in any driver but never upstream their code...

Rafal,  please let us know if this is okay with you or any 
concern/possible break of existing system.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4212 bytes)