linux-kernel - Re: [PATCH v2 2/5] dt-bindings: mmc: sdhci-msm: constrain reg-names perp variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Jul 2022 09:02:53 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Bhupesh Sharma <bhupesh.sharma@...aro.org>,
        Linux MMC List <linux-mmc@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH v2 2/5] dt-bindings: mmc: sdhci-msm: constrain reg-names
 perp variants

On 11/07/2022 17:11, Doug Anderson wrote:
> Hi,
> 
> On Mon, Jul 11, 2022 at 7:53 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
>>
>> On 11/07/2022 16:52, Doug Anderson wrote:
>>> Hi
>>>
>>> On Mon, Jul 11, 2022 at 1:29 AM Krzysztof Kozlowski
>>> <krzysztof.kozlowski@...aro.org> wrote:
>>>>
>>>> The entries in arrays must have fixed order, so the bindings and Linux
>>>> driver expecting various combinations of 'reg' addresses was never
>>>> actually conforming to guidelines.
>>>>
>>>> The 'core' reg entry is valid only for SDCC v4 and lower, so disallow it
>>>> in SDCC v5.  SDCC v4 supports CQE and ICE, so allow them, even though
>>>> the qcom,sdhci-msm-v4 compatible is used also for earlier SoCs with SDCC
>>>> v2 or v3, so it is not entirely accurate.
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>>>
>>>> ---
>>>>
>>>> Changes since v1:
>>>> 1. Rework the patch based on Doug's feedback.
>>>> ---
>>>>  .../devicetree/bindings/mmc/sdhci-msm.yaml    | 61 ++++++++++++-------
>>>>  1 file changed, 38 insertions(+), 23 deletions(-)
>>>
>>> In the ${SUBJECT} I'm not sure what a "perp variant" is. Is that a
>>> typo or just a phrase I'm not aware of?
>>
>> Should be:
>> "per variants"
>>
>>>
>>>
>>>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>>> index fc6e5221985a..2f0fdd65e908 100644
>>>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>>> @@ -49,33 +49,11 @@ properties:
>>>>
>>>>    reg:
>>>>      minItems: 1
>>>> -    items:
>>>> -      - description: Host controller register map
>>>> -      - description: SD Core register map
>>>> -      - description: CQE register map
>>>> -      - description: Inline Crypto Engine register map
>>>> +    maxItems: 4
>>>>
>>>>    reg-names:
>>>>      minItems: 1
>>>>      maxItems: 4
>>>> -    oneOf:
>>>> -      - items:
>>>> -          - const: hc
>>>> -      - items:
>>>> -          - const: hc
>>>> -          - const: core
>>>> -      - items:
>>>> -          - const: hc
>>>> -          - const: cqhci
>>>> -      - items:
>>>> -          - const: hc
>>>> -          - const: cqhci
>>>> -          - const: ice
>>>> -      - items:
>>>> -          - const: hc
>>>> -          - const: core
>>>> -          - const: cqhci
>>>> -          - const: ice
>>>>
>>>>    clocks:
>>>>      minItems: 3
>>>> @@ -177,6 +155,43 @@ required:
>>>>  allOf:
>>>>    - $ref: mmc-controller.yaml#
>>>>
>>>> +  - if:
>>>> +      properties:
>>>> +        compatible:
>>>> +          contains:
>>>> +            enum:
>>>> +              - qcom,sdhci-msm-v4
>>>> +    then:
>>>> +      properties:
>>>> +        reg:
>>>> +          minItems: 2
>>>> +          items:
>>>> +            - description: Host controller register map
>>>> +            - description: SD Core register map
>>>> +            - description: CQE register map
>>>> +            - description: Inline Crypto Engine register map
>>>> +        reg-names:
>>>> +          minItems: 2
>>>> +          items:
>>>> +            - const: hc
>>>> +            - const: core
>>>> +            - const: cqhci
>>>> +            - const: ice
>>>> +    else:
>>>> +      properties:
>>>> +        reg:
>>>> +          minItems: 1
>>>> +          items:
>>>> +            - description: Host controller register map
>>>> +            - description: CQE register map
>>>> +            - description: Inline Crypto Engine register map
>>>> +        reg-names:
>>>> +          minItems: 1
>>>> +          items:
>>>> +            - const: hc
>>>> +            - const: cqhci
>>>> +            - const: ice
>>>
>>> Do you need to set "maxItems" here? If you don't then will it inherit
>>> the maxItems of 4 from above?
>>
>> No, items determine the size instead.
> 
> Can you just remove the "maxItems" from above then? Does it buy us anything?

There is no maxItems directly here...

> 
> In any case, with the ${SUBJECT} fixed:
> 
> Reviewed-by: Douglas Anderson <dianders@...omium.org>


Best regards,
Krzysztof