linux-kernel - Re: [PATCH 1/3] drm/bridge: it6505: Modified power sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG3jFystTA3sD2nWJHPYq39WxRwjVt4qj2DMDk2Khh1kR=8ntg@mail.gmail.com>
Date:   Tue, 12 Jul 2022 10:07:41 +0200
From:   Robert Foss <robert.foss@...aro.org>
To:     allen <allen.chen@....com.tw>
Cc:     Pin-yen Lin <treapking@...gle.com>,
        Jau-Chih Tseng <Jau-Chih.Tseng@....com.tw>,
        Kenneth Hung <Kenneth.Hung@....com.tw>,
        Hermes Wu <Hermes.Wu@....com.tw>,
        Pin-Yen Lin <treapking@...omium.org>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        "open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] drm/bridge: it6505: Modified power sequence

Hi Allen,

On Thu, 7 Jul 2022 at 10:06, allen <allen.chen@....com.tw> wrote:
>
> From: allen chen <allen.chen@....com.tw>
>
> Change power sequence to meet it6505 data sheet requirement when boot on.
>
> Signed-off-by: Pin-Yen Lin <treapking@...omium.org>
> Signed-off-by: Allen Chen <allen.chen@....com.tw>
>
> ---
>  drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
> index 2d119e3016b3..aa5e0aa1af85 100644
> --- a/drivers/gpu/drm/bridge/ite-it6505.c
> +++ b/drivers/gpu/drm/bridge/ite-it6505.c
> @@ -3029,7 +3029,7 @@ static int it6505_init_pdata(struct it6505 *it6505)
>                 return PTR_ERR(pdata->ovdd);
>         }
>
> -       pdata->gpiod_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> +       pdata->gpiod_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);

Making this change is problematic since it requires a corresponding
change in all of the device trees that use this device. It's against
policy to change this interface after it has been introduced.

Unless anyone thinks otherwise, I would like to see this patch dropped.

>         if (IS_ERR(pdata->gpiod_reset)) {
>                 dev_err(dev, "gpiod_reset gpio not found");
>                 return PTR_ERR(pdata->gpiod_reset);
> --
> 2.25.1
>