[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+KjhYWukGxZUMMch_vFe=TNYCD0-jmuwO2520oUVDPE2kE1Rw@mail.gmail.com>
Date: Thu, 4 Aug 2022 09:45:07 +0200
From: Sebastian Würl <sebastian.wuerl@...ratech.com>
To: Marc Kleine-Budde <mkl@...gutronix.de>
Cc: Wolfgang Grandegger <wg@...ndegger.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Vincent Mailhol <mailhol.vincent@...adoo.fr>,
Stefan Mätje <stefan.maetje@....eu>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Oliver Hartkopp <socketcan@...tkopp.net>,
Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>,
Christian Pellegrin <chripell@...e.org>,
linux-can@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] can: mcp251x: Fix race condition on receive interrupt
On Thu, Aug 4, 2022 at 9:06 AM Marc Kleine-Budde <mkl@...gutronix.de> wrote:
>
> Another optimization idea: Do we need to re-read the eflag1? "eflag" is
> for error handling only and you're optimizing the good path.
I'd argue if a new message entered mailbox 1, this also potentially
changed the error state, so we need to read it.
Thanks a lot for your feedback! Will post v3 soon.
Also I'm sorry for spam in anyones inbox, I didn't get my mailing
program to produce plain-text for the last mail.
best,
Sebastian
Powered by blists - more mailing lists