linux-kernel - Re: [PATCH v3 2/2] nvmem: lan9662-otp: add support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2022 10:29:09 +0300
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Horatiu Vultur <horatiu.vultur@...rochip.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     srinivas.kandagatla@...aro.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v3 2/2] nvmem: lan9662-otp: add support.

On 31/08/2022 09:42, Horatiu Vultur wrote:

> +static const struct of_device_id lan9662_otp_match[] = {
> +	{ .compatible = "microchip,lan9662-otp", },
> +	{ .compatible = "microchip,lan9668-otp", },

This is still wrong, does not match your bindings at all and still
duplicates entries without driver data. One entry - 9662.

Best regards,
Krzysztof