linux-kernel - Re: [PATCH v2 2/2] iio: adc: add max11205 adc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcszDjWXhjX+E7Xe0a=1_2tVpLNk8UWaAP7p=dKGMCUdw@mail.gmail.com>
Date:   Sun, 4 Sep 2022 22:49:33 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Ramona Bolboaca <ramona.bolboaca@...log.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] iio: adc: add max11205 adc driver

On Sun, Sep 4, 2022 at 7:31 PM Jonathan Cameron <jic23@...nel.org> wrote:
> On Sun, 4 Sep 2022 16:50:03 +0100
> Jonathan Cameron <jic23@...nel.org> wrote:
> > On Wed, 31 Aug 2022 16:30:21 +0300
> > Ramona Bolboaca <ramona.bolboaca@...log.com> wrote:

...

> > Given the requested changes below and those from Andy and Kryzstof are minor, I'll just
> > tweak them whilst applying.
>
> On that note, applied to the togreg branch of iio.git (with changes as noted)
> and pushed out as testing for 0-day to see if it can find anything we missed.

If you are not too lazy and have time to tweak one completely minor
thingy, see below.

...

> > @@ -81,12 +81,12 @@ static const struct iio_chan_spec max11205_channels[] = {
> >                         .endianness = IIO_BE

+ A comma here :-)


> >                 },
> >                 .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
> > -               BIT(IIO_CHAN_INFO_SAMP_FREQ) |
> > -               BIT(IIO_CHAN_INFO_SCALE),
> > +                                     BIT(IIO_CHAN_INFO_SAMP_FREQ) |
> > +                                     BIT(IIO_CHAN_INFO_SCALE),
> >         },

-- 
With Best Regards,
Andy Shevchenko