linux-kernel - Re: [PATCH v4 00/21] Variety of fixes and new features for mr75203 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YxdYjWYCR7YCodTX@smile.fi.intel.com>
Date:   Tue, 6 Sep 2022 17:26:21 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Eliav Farber <farbere@...zon.com>
Cc:     jdelvare@...e.com, linux@...ck-us.net, robh+dt@...nel.org,
        p.zabel@...gutronix.de, rtanwar@...linear.com,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, hhhawa@...zon.com, jonnyc@...zon.com
Subject: Re: [PATCH v4 00/21] Variety of fixes and new features for mr75203
 driver

On Tue, Sep 06, 2022 at 08:33:35AM +0000, Eliav Farber wrote:
> List of fixes:
>  - Fix "intel,vm-map" property to be optional.
>  - Fix VM sensor allocation when "intel,vm-map" not defined.
>  - Fix multi-channel voltage reading.
>  - Fix voltage equation for negative source input.
>  - Modify the temperature equation according to series 5 datasheet.
>  - Fix coding style issue.
> 
> List of new features:
>  - Modify "reset" property to be optional.
>  - Add optional "moortec,vm-active-channels" property to define the number
>    of active channels per VM.
>  - Add support for mr76006 pre-scaler to multiply the voltage result by 2.
>  - Add support for series 6 temperature equation.
>  - Add coefficient properties to fine tune the temperature equation.
>  - Add debugfs to read and write temperature coefficients

For all code patches (means no DT ones)
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> ---------
> 
> Changes between v3 and v4:
> *) Provide a Fixes tag for all fixes in the series.
> *) Start series with fixes.
> *) New patch to add description in moortec,mr75203.yaml.
> *) New patch to add moortec to vendor-prefixes.
> *) Fix moortec,mr75203.yaml checker errors.
> *) Remove validation of device-tree parameters.
> *) Fix per patch specific comments (detailed in each patch).
> 
> Changes between v2 and v3:
> *) Add "moortec" prefix to all new device-tree properties.
> *) Change order of patches.
> *) Add explanations to better understand the changes.
> *) Change "reset" property to be optional and remove the
>   "reset-control-skip" property.
> *) Split the patch for "fix multi-channel voltage reading" to two
>    patches.
> *) Change pre-scaler property format and fix typo (scalar --> scaler).
> *) Fix voltage equation to support negative values instead of limiting
>    value to zero.
> *) Temperature equation - protect from overflow and add clamping.
> *) Add new "moortec,ts-series" property to select between temperature
>    equation of series 5 or series 6.
> 
> Changes between v1 and v2:
>  *) Fix compilation error for patch 08/16:
>     "warning: ISO C90 forbids variable length array"
> 
> ---------
> 
> Eliav Farber (21):
>   hwmon: (mr75203) fix coding style space errors
>   dt-bindings: hwmon: (mr75203) fix "intel,vm-map" property to be
>     optional
>   hwmon: (mr75203) fix VM sensor allocation when "intel,vm-map" not
>     defined
>   hwmon: (mr75203) update pvt->v_num and vm_num to the actual number of
>     used sensors
>   hwmon: (mr75203) fix voltage equation for negative source input
>   hwmon: (mr75203) fix multi-channel voltage reading
>   hwmon: (mr75203) enable polling for all VM channels
>   dt-bindings: hwmon: (mr75203) add description for Moortec's PVT
>     controller
>   dt-bindings: hwmon: (mr75203) change "resets" property to be optional
>   hwmon: (mr75203) skip reset-control deassert for SOCs that don't
>     support it
>   dt-bindings: vendor-prefixes: add vendor prefix for Moortec
>   dt-bindings: hwmon: (mr75203) add "moortec,vm-active-channels"
>     property
>   hwmon: (mr75203) add VM active channel support
>   dt-bindings: hwmon: (mr75203) add "moortec,vm-pre-scaler-x2" property
>   hwmon: (mr75203) add VM pre-scaler x2 support
>   hwmon: (mr75203) modify the temperature equation according to series 5
>     datasheet
>   dt-bindings: hwmon: (mr75203) add "moortec,ts-series" property
>   hwmon: (mr75203) add support for series 6 temperature equation
>   dt-bindings: hwmon: (mr75203) add coefficient properties for the
>     thermal equation
>   hwmon: (mr75203) parse temperature coefficients from device-tree
>   hwmon: (mr75203) add debugfs to read and write temperature
>     coefficients
> 
>  .../bindings/hwmon/moortec,mr75203.yaml       |  97 ++++-
>  .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
>  drivers/hwmon/mr75203.c                       | 387 +++++++++++++++---
>  3 files changed, 421 insertions(+), 65 deletions(-)
> 
> -- 
> 2.37.1
> 

-- 
With Best Regards,
Andy Shevchenko