linux-kernel - Re: [PATCH] dt-bindings: dma: Make minor fixes to qcom,bam-dma binding doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3205b59-6b6e-2983-9e2a-39354cd1803e@linaro.org>
Date:   Mon, 26 Sep 2022 01:25:45 +0530
From:   Bhupesh Sharma <bhupesh.sharma@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        devicetree@...r.kernel.org
Cc:     linux-arm-msm@...r.kernel.org, bhupesh.linux@...il.com,
        linux-kernel@...r.kernel.org, vkoul@...nel.org, agross@...nel.org,
        dmaengine@...r.kernel.org, konrad.dybcio@...ainline.org,
        robh+dt@...nel.org, andersson@...nel.org
Subject: Re: [PATCH] dt-bindings: dma: Make minor fixes to qcom,bam-dma
 binding doc

On 9/18/22 2:19 PM, Krzysztof Kozlowski wrote:
> On 18/09/2022 09:11, Bhupesh Sharma wrote:
>> As a user recently noted, the qcom,bam-dma binding document
>> describes the BAM DMA node incorrectly.
> 
> It's a bit confusing - what is exactly incorrectly described by binding?
> You did not make any changes to the binding itself...

Sorry for the late reply. Your comment just skipped through my mail 
filters :(

I understand your point. I should have made the commit message more 
descriptive (infact now I look at it, I see some key words are actually 
missing from the commit message).

The commit message should infact read as:

"As a user recently noted, the qcom,bam-dma binding document
describes the BAM DMA node *in the example section* incorrectly. Fix the 
same by making it consistent with the node present inside 'qcom-msm8974' 
dts file, *namely the 'reg' and 'interrupt' values which are incorrect. 
While looking at the example in the binding document, the user noted 
that its incorrect when compared with both the 'msm8974' upstream as 
well as downstream dts files.*

I hope the bold text (which I added above), helps clear the purpose of 
the patch better.

Please let me know your views.

Thanks,
Bhupesh