linux-kernel - Re: [PATCH v3 0/5] Fix crash when using Qcom LLCC/EDAC drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 Oct 2022 12:34:15 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     bjorn.andersson@...aro.org, bp@...en8.de, mchehab@...nel.org
Cc:     james.morse@....com, rric@...nel.org,
        linux-arm-msm@...r.kernel.org, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org, quic_tsoni@...cinc.com,
        quic_saipraka@...cinc.com
Subject: Re: [PATCH v3 0/5] Fix crash when using Qcom LLCC/EDAC drivers

On Thu, Aug 25, 2022 at 10:08:54AM +0530, Manivannan Sadhasivam wrote:
> Hello,
> 
> This series fixes the crash seen on the Qualcomm SM8450 chipset with the
> LLCC/EDAC drivers. The problem was due to the Qcom EDAC driver using the
> fixed LLCC register offsets for detecting the LLCC errors.
> 
> This seems to have worked for SoCs till SM8450. But in SM8450, the LLCC
> register offsets were changed. So accessing the fixed offsets causes the
> crash on this platform.
> 
> So for fixing this issue, and also to make it work on future SoCs, let's
> pass the LLCC offsets from the Qcom LLCC driver based on the individual
> SoCs and let the EDAC driver make use of them.
> 
> This series has been tested on SM8450 based dev board.
> 

Since the LLCC patches are already merged, can we get the EDAC patches to be
merged for v6.1?

Thanks,
Mani

> Thanks,
> Mani
> 
> Changes in v3:
> 
> * Instead of using SoC specific register offset naming convention, used
>   LLCC version based as suggested by Sai
> * Fixed the existing reg_offset naming convention to clearly represent
>   the LLCC version from which the offsets were changed
> * Added Sai's Acked-by to MAINTAINERS patch
> * Added a new patch that removes an extra error no assignment
> 
> Changes in v2:
> 
> * Volunteered myself as a maintainer for the EDAC driver since the current
>   maintainers have left Qualcomm and I couldn't get hold of them.
> 
> Manivannan Sadhasivam (5):
>   soc: qcom: llcc: Rename reg_offset structs to reflect LLCC version
>   soc: qcom: llcc: Pass LLCC version based register offsets to EDAC
>     driver
>   EDAC/qcom: Get rid of hardcoded register offsets
>   EDAC/qcom: Remove extra error no assignment in qcom_llcc_core_setup()
>   MAINTAINERS: Add myself as the maintainer for qcom_edac driver
> 
>  MAINTAINERS                        |   3 +-
>  drivers/edac/qcom_edac.c           | 119 ++++++++++++++---------------
>  drivers/soc/qcom/llcc-qcom.c       |  92 +++++++++++++++++++---
>  include/linux/soc/qcom/llcc-qcom.h |  36 +++++++--
>  4 files changed, 170 insertions(+), 80 deletions(-)
> 
> -- 
> 2.25.1
> 

-- 
மணிவண்ணன் சதாசிவம்