linux-kernel - Re: [PATCH v2 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e21f49b7-4a44-c016-0e52-3ab018978f31@linaro.org>
Date:   Tue, 4 Oct 2022 11:41:00 +0200
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Satya Priya <quic_c_skakit@...cinc.com>,
        Andy Gross <agross@...nel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Rob Herring <robh+dt@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Lee Jones <lee@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Alessandro Zummo <a.zummo@...ertech.it>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-input@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-rtc@...r.kernel.org
Subject: Re: [PATCH v2 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert
 to dt-schema

Hi,

On 04/10/2022 10:59, Krzysztof Kozlowski wrote:
> On 04/10/2022 10:08, Neil Armstrong wrote:
>> Convert input/qcom,pm8xxx-pwrkey.txt to YAML, and take in account that
>> the PM8921 pwrkey compatible is used as fallback for the PM8018 pwrkey.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
>>
> 
> You miss diffstat... but I guess it's result of b4?

Yep, I'll update with last release to get it back.

> 
>> diff --git a/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml b/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml
>> new file mode 100644
>> index 000000000000..ae38c4ef4932
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml
>> @@ -0,0 +1,77 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/input/qcom,pm8921-pwrkey.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm PM8921 PMIC Power Key
>> +
>> +maintainers:
>> +  - Andy Gross <agross@...nel.org>
>> +  - Bjorn Andersson <andersson@...nel.org>
> 
> Keep only Bjorn. Andy did not review much for some time.

Ack

> 
>> +
>> +allOf:
>> +  - $ref: input.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - enum:
>> +          - qcom,pm8921-pwrkey
>> +          - qcom,pm8058-pwrkey
>> +      - items:
>> +          - enum:
>> +              - qcom,pm8018-pwrkey
>> +          - const: qcom,pm8921-pwrkey
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 2
>> +    description: |
>> +          The first interrupt specifies the key release interrupt
>> +          and the second interrupt specifies the key press interrupt.
> 
> In such case better to drop maxItems and description and write it:
> 
> items:
>    - description: key release interrupt
>    - description: key press interrupt
> 
> (maybe even the "interrupt" word could be skipped...)

Ack, will do that without the interrupt word

> 
>> +
>> +  debounce:
>> +    description: |
>> +          Time in microseconds that key must be pressed or
>> +          released for state change interrupt to trigger.
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +
>> +  pull-up:
>> +    description: |
>> +           Presence of this property indicates that the KPDPWR_N
>> +           pin should be configured for pull up.
>> +    $ref: /schemas/types.yaml#/definitions/flag
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +   #include <dt-bindings/interrupt-controller/irq.h>
>> +   ssbi {
>> +   #address-cells = <1>;
>> +   #size-cells = <0>;
> 
> Messed indentation.
>> +
>> +     pmic@0 {
>> +       reg = <0x0>;
>> +       #address-cells = <1>;
>> +       #size-cells = <0>;
>> +
>> +       pwrkey@1c {
>> +          compatible = "qcom,pm8921-pwrkey";
> 
> Messed up indentation. For entire DTS example keep 2 or 4 spaces.
> 
>> +          reg = <0x1c>;
>> +          interrupt-parent = <&pmicint>;
>> +          interrupts = <50 1>, <51 1>;
> 
> Use defines for interrupt flags.
> 
>> +          debounce = <15625>;
>> +          pull-up;
>> +       };
>> +     };
>> +   };

Will fix the example,

> 
> Best regards,
> Krzysztof
> 

Thanks,
Neil