linux-kernel - Re: [PATCH 3/6] arm: dts: qcom: mdm9615: wp8548-mangoh-green: fix sx150xq node names and probe-reset property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <450d2490-2640-6a4a-946f-e401ba68d52c@somainline.org>
Date:   Fri, 7 Oct 2022 21:38:26 +0200
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Neil Armstrong <neil.armstrong@...aro.org>,
        Andy Gross <agross@...nel.org>, Lee Jones <lee@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 3/6] arm: dts: qcom: mdm9615: wp8548-mangoh-green: fix
 sx150xq node names and probe-reset property



On 6.10.2022 11:58, Neil Armstrong wrote:
> Fix the sx150xq node names to pinctrl and use the right probe-reset property.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
> ---
Could you please also fix up the property order (may be in a separate patchset ofc)?

Reviewed-by: Konrad Dybcio <konrad.dybcio@...ainline.org>

Konrad
>  arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
> index 30a110984597..a8304769b509 100644
> --- a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
> +++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
> @@ -116,7 +116,7 @@ i2c@4 {
>  			#size-cells = <0>;
>  			reg = <4>;
>  
> -			gpioext0: gpio@3e {
> +			gpioext0: pinctrl@3e {
>  				/* GPIO Expander 0 Mapping :
>  				 * - 0: ARDUINO_RESET_Level shift
>  				 * - 1: BattChrgr_PG_N
> @@ -142,7 +142,7 @@ gpioext0: gpio@3e {
>  				interrupt-parent = <&gpioext1>;
>  				interrupts = <0 IRQ_TYPE_EDGE_FALLING>;
>  
> -				probe-reset;
> +				semtech,probe-reset;
>  
>  				gpio-controller;
>  				interrupt-controller;
> @@ -154,7 +154,7 @@ i2c@5 {
>  			#size-cells = <0>;
>  			reg = <5>;
>  
> -			gpioext1: gpio@3f {
> +			gpioext1: pinctrl@3f {
>  				/* GPIO Expander 1 Mapping :
>  				 * - 0: GPIOEXP_INT1
>  				 * - 1: Battery detect
> @@ -183,7 +183,7 @@ gpioext1: gpio@3f {
>  				interrupt-parent = <&msmgpio>;
>  				interrupts = <0 IRQ_TYPE_EDGE_FALLING>;
>  
> -				probe-reset;
> +				semtech,probe-reset;
>  
>  				gpio-controller;
>  				interrupt-controller;
> @@ -195,7 +195,7 @@ i2c@6 {
>  			#size-cells = <0>;
>  			reg = <6>;
>  
> -			gpioext2: gpio@70 {
> +			gpioext2: pinctrl@70 {
>  				/* GPIO Expander 2 Mapping :
>  				 * - 0: USB_HUB_INTn
>  				 * - 1: HUB_CONNECT
> @@ -221,7 +221,7 @@ gpioext2: gpio@70 {
>  				interrupt-parent = <&gpioext1>;
>  				interrupts = <14 IRQ_TYPE_EDGE_FALLING>;
>  
> -				probe-reset;
> +				semtech,probe-reset;
>  
>  				gpio-controller;
>  				interrupt-controller;
>