linux-kernel - Re: [PATCH] Fixes: 91cefefb6991 ("ACPI: PCC: replace wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221017182035.3g67uudttl6k5gag@bogus>
Date:   Mon, 17 Oct 2022 19:20:35 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Manank Patel <pmanank200502@...il.com>
Cc:     rafael@...nel.org, lenb@...nel.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fixes: 91cefefb6991 ("ACPI: PCC: replace
 wait_for_completion()")

On Mon, Oct 17, 2022 at 11:19:15PM +0530, Manank Patel wrote:
> Fixed unintentional u32 overflow by changing PCC_CMD_WAIT_RETRIES_NUM to 500ULL
> 

You just need to add the below fixes line above Signed-off tag. You seemed
to have changed the $subject. Please retain the origin subject

Please post it again cleanly marking it as v2(as in the subject must be
[PATCH v2] "ACPI: PCC: Fix unintentional integer overflow" 

Fixes: 91cefefb6991 ("ACPI: PCC: replace wait_for_completion()")
> Signed-off-by: Manank Patel <pmanank200502@...il.com>
> ---
> 
> Sorry for the spam, I made a mistake in the previous patch (I had a confusion 
> in your suggestion about the Fixes tag).As you would have realised, i'm new 
> to this, and not so familiar with the workflow (Though I have read the 
> Documentation). Let me know if you have any suggestions.
>

Add a text here pointing what changed from v1->v2
v1->v2:
	Change the macro itself ULL instead typecasting in the code

Hope this helps.

With all these changes incorporated in v2, you can add my
Acked-by: Sudeep Holla <sudeep.holla@....com>

-- 
Regards,
Sudeep