linux-kernel - [PATCH v2] "ACPI: PCC: Fix unintentional integer overflow"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221017184338.64152-1-pmanank200502@gmail.com>
Date:   Tue, 18 Oct 2022 00:13:39 +0530
From:   Manank Patel <pmanank200502@...il.com>
To:     rafael@...nel.org
Cc:     lenb@...nel.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Manank Patel <pmanank200502@...il.com>,
        Sudeep Holla <sudeep.holla@....com>
Subject: [PATCH v2] "ACPI: PCC: Fix unintentional integer overflow"

Fixed unintentional u32 overflow by changing PCC_CMD_WAIT_RETRIES_NUM to 500ULL

Fixes: 91cefefb6991 ("ACPI: PCC: replace wait_for_completion()")

Signed-off-by: Manank Patel <pmanank200502@...il.com>
Acked-by: Sudeep Holla <sudeep.holla@....com>

---
Thank you so much @sudeep for your clarifications!

Changelog:
v1->v2:
        Change the macro itself to ULL instead of typecasting in the
        code

 drivers/acpi/acpi_pcc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/acpi_pcc.c b/drivers/acpi/acpi_pcc.c
index ee4ce5ba1fb2..3e252be047b8 100644
--- a/drivers/acpi/acpi_pcc.c
+++ b/drivers/acpi/acpi_pcc.c
@@ -27,7 +27,7 @@
  * Arbitrary retries in case the remote processor is slow to respond
  * to PCC commands
  */
-#define PCC_CMD_WAIT_RETRIES_NUM	500
+#define PCC_CMD_WAIT_RETRIES_NUM	500ULL
 
 struct pcc_data {
 	struct pcc_mbox_chan *pcc_chan;
-- 
2.38.0