linux-kernel - Re: [PATCH v3 1/6] staging: vt6655: fix lines ending in a '('

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHJEyKVh9J-OMS=fBU7oiFtx7U00o2MFhQKRN2i9DhE7g3D_hg@mail.gmail.com>
Date:   Sat, 22 Oct 2022 09:24:02 +0100
From:   Tanju Brunostar <tanjubrunostar0@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy@...ts.linux.dev
Subject: Re: [PATCH v3 1/6] staging: vt6655: fix lines ending in a '('

On Sat, Oct 22, 2022 at 9:17 AM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Sat, Oct 22, 2022 at 07:06:07AM +0000, Tanjuate Brunostar wrote:
> > fix serveral checkpatch errors related to lines ending with a '(' by
> > refactoring the code lines
> >
> > Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@...il.com>
> > ---
> >  drivers/staging/vt6655/rxtx.c | 149 ++++++++++++++--------------------
> >  1 file changed, 63 insertions(+), 86 deletions(-)
> >
> > diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> > index 1e5036121665..f9d0b00d7cff 100644
> > --- a/drivers/staging/vt6655/rxtx.c
> > +++ b/drivers/staging/vt6655/rxtx.c
> > @@ -141,13 +141,11 @@ static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate)
> >   */
> >  static
> >  unsigned int
> > -s_uGetTxRsvTime(
> > -     struct vnt_private *pDevice,
> > -     unsigned char byPktType,
> > -     unsigned int cbFrameLength,
> > -     unsigned short wRate,
> > -     bool bNeedAck
> > -)
> > +s_uGetTxRsvTime(struct vnt_private *pDevice,
>
> You have a strange mix of choices here for how you changed the code.
>
> This time you did not move the "static" or "unsigned int" to the same
> line as the function name, but then:
>
> > +             unsigned char byPktType,
> > +             unsigned int cbFrameLength,
> > +             unsigned short wRate,
> > +             bool bNeedAck)
> >  {
> >       unsigned int uDataTime, uAckTime;
> >
> > @@ -215,19 +213,16 @@ static __le16 get_rtscts_time(struct vnt_private *priv,
> >
> >  /* byFreqType 0: 5GHz, 1:2.4Ghz */
> >  static
> > -unsigned int
> > -s_uGetDataDuration(
> > -     struct vnt_private *pDevice,
> > -     unsigned char byDurType,
> > -     unsigned int cbFrameLength,
> > -     unsigned char byPktType,
> > -     unsigned short wRate,
> > -     bool bNeedAck,
> > -     unsigned int uFragIdx,
> > -     unsigned int cbLastFragmentSize,
> > -     unsigned int uMACfragNum,
> > -     unsigned char byFBOption
> > -)
> > +unsigned int s_uGetDataDuration(struct vnt_private *pDevice,
>
> You moved "unsigned int" here, but then:
>
>
> > +                             unsigned char byDurType,
> > +                             unsigned int cbFrameLength,
> > +                             unsigned char byPktType,
> > +                             unsigned short wRate,
> > +                             bool bNeedAck,
> > +                             unsigned int uFragIdx,
> > +                             unsigned int cbLastFragmentSize,
> > +                             unsigned int uMACfragNum,
> > +                             unsigned char byFBOption)
> >  {
> >       bool bLastFrag = false;
> >       unsigned int uAckTime = 0, uNextPktTime = 0, len;
> > @@ -316,17 +311,13 @@ s_uGetDataDuration(
> >  }
> >
> >  /* byFreqType: 0=>5GHZ 1=>2.4GHZ */
> > -static
> > -__le16
> > -s_uGetRTSCTSDuration(
> > -     struct vnt_private *pDevice,
> > -     unsigned char byDurType,
> > -     unsigned int cbFrameLength,
> > -     unsigned char byPktType,
> > -     unsigned short wRate,
> > -     bool bNeedAck,
> > -     unsigned char byFBOption
> > -)
> > +static __le16 s_uGetRTSCTSDuration(struct vnt_private *pDevice,
>
> You did both the static and the return type here.
>
> Pick one style and stick with it please.  Consistancy matters, that is
> why we have a coding style to start with.  Brains and pattern matching
> and all that.
>
> In this case, this last one (both static and the return type), should be
> used.
>
> thanks,
>
> greg k-h

OK thanks