linux-kernel - Re: [PATCH] scsi: lpfc: remove redundant pointer lp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 1 Nov 2022 22:49:14 +0800
From:   kernel test robot <lkp@...el.com>
To:     Colin Ian King <colin.i.king@...il.com>,
        James Smart <james.smart@...adcom.com>,
        Dick Kennedy <dick.kennedy@...adcom.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: lpfc: remove redundant pointer lp

Hi Colin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on jejb-scsi/for-next linus/master v6.1-rc3 next-20221101]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Colin-Ian-King/scsi-lpfc-remove-redundant-pointer-lp/20221101-195936
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link:    https://lore.kernel.org/r/20221101115657.48267-1-colin.i.king%40gmail.com
patch subject: [PATCH] scsi: lpfc: remove redundant pointer lp
config: ia64-allyesconfig
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/e11ce9b9f1589e7088f17b72cd4df1c2c0bbb1d1
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Colin-Ian-King/scsi-lpfc-remove-redundant-pointer-lp/20221101-195936
        git checkout e11ce9b9f1589e7088f17b72cd4df1c2c0bbb1d1
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/scsi/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/scsi/lpfc/lpfc_els.c: In function 'lpfc_els_rcv_farpr':
>> drivers/scsi/lpfc/lpfc_els.c:9175:29: warning: variable 'pcmd' set but not used [-Wunused-but-set-variable]
    9175 |         struct lpfc_dmabuf *pcmd;
         |                             ^~~~


vim +/pcmd +9175 drivers/scsi/lpfc/lpfc_els.c

dea3101e0a5c89 James Bottomley 2005-04-17  9156  
e59058c44025d7 James Smart     2008-08-24  9157  /**
3621a710a7dbb2 James Smart     2009-04-06  9158   * lpfc_els_rcv_farpr - Process an unsolicited farp response iocb
e59058c44025d7 James Smart     2008-08-24  9159   * @vport: pointer to a host virtual N_Port data structure.
e59058c44025d7 James Smart     2008-08-24  9160   * @cmdiocb: pointer to lpfc command iocb data structure.
e59058c44025d7 James Smart     2008-08-24  9161   * @ndlp: pointer to a node-list data structure.
e59058c44025d7 James Smart     2008-08-24  9162   *
e59058c44025d7 James Smart     2008-08-24  9163   * This routine processes Fibre Channel Address Resolution Protocol
e59058c44025d7 James Smart     2008-08-24  9164   * Response (FARPR) IOCB received as an ELS unsolicited event. It simply
e59058c44025d7 James Smart     2008-08-24  9165   * invokes the lpfc_els_rsp_acc() routine to the remote node to accept
e59058c44025d7 James Smart     2008-08-24  9166   * the FARP response request.
e59058c44025d7 James Smart     2008-08-24  9167   *
e59058c44025d7 James Smart     2008-08-24  9168   * Return code
e59058c44025d7 James Smart     2008-08-24  9169   *   0 - Successfully processed FARPR IOCB (currently always return 0)
e59058c44025d7 James Smart     2008-08-24  9170   **/
dea3101e0a5c89 James Bottomley 2005-04-17  9171  static int
2e0fef85e098f6 James Smart     2007-06-17  9172  lpfc_els_rcv_farpr(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
2e0fef85e098f6 James Smart     2007-06-17  9173  		   struct lpfc_nodelist  *ndlp)
dea3101e0a5c89 James Bottomley 2005-04-17  9174  {
dea3101e0a5c89 James Bottomley 2005-04-17 @9175  	struct lpfc_dmabuf *pcmd;
b27cbd55495093 Bart Van Assche 2019-03-28  9176  	uint32_t did;
dea3101e0a5c89 James Bottomley 2005-04-17  9177  
3bea83b68d5447 James Smart     2022-02-24  9178  	did = get_job_els_rsp64_did(vport->phba, cmdiocb);
d51cf5bd926c7d James Smart     2022-04-12  9179  	pcmd = cmdiocb->cmd_dmabuf;
dea3101e0a5c89 James Bottomley 2005-04-17  9180  
dea3101e0a5c89 James Bottomley 2005-04-17  9181  	/* FARP-RSP received from DID <did> */
e8b62011d88d6f James Smart     2007-08-02  9182  	lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS,
e8b62011d88d6f James Smart     2007-08-02  9183  			 "0600 FARP-RSP received from DID x%x\n", did);
dea3101e0a5c89 James Bottomley 2005-04-17  9184  	/* ACCEPT the Farp resp request */
51ef4c26891a73 James Smart     2007-08-02  9185  	lpfc_els_rsp_acc(vport, ELS_CMD_ACC, cmdiocb, ndlp, NULL);
dea3101e0a5c89 James Bottomley 2005-04-17  9186  
dea3101e0a5c89 James Bottomley 2005-04-17  9187  	return 0;
dea3101e0a5c89 James Bottomley 2005-04-17  9188  }
dea3101e0a5c89 James Bottomley 2005-04-17  9189  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (322067 bytes)