linux-kernel - Re: [PATCH] scsi: lpfc: remove redundant pointer lp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1y1smi03t.fsf@ca-mkp.ca.oracle.com>
Date:   Mon, 07 Nov 2022 22:46:56 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     James Smart <james.smart@...adcom.com>,
        Colin Ian King <colin.i.king@...il.com>
Cc:     Dick Kennedy <dick.kennedy@...adcom.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: lpfc: remove redundant pointer lp


Colin,

> Pointer lp is being initialized and incremented but the result
> is never read. The pointer is redundant and can be removed.

> @@ -9173,14 +9173,11 @@ lpfc_els_rcv_farpr(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
>  		   struct lpfc_nodelist  *ndlp)

Looks like this function has been dubious for a long time. From a quick
glance it doesn't appear to have done anything useful with those
variable assignments since back in the 4.x days.

James, please have a look.

-- 
Martin K. Petersen	Oracle Linux Engineering