[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202211090127.c1LB7Sle-lkp@intel.com>
Date: Wed, 9 Nov 2022 01:17:15 +0800
From: kernel test robot <lkp@...el.com>
To: Pierre Gondois <pierre.gondois@....com>,
linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev,
Pierre Gondois <pierre.gondois@....com>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Len Brown <lenb@...nel.org>,
Sudeep Holla <sudeep.holla@....com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Gavin Shan <gshan@...hat.com>,
Peter Chen <peter.chen@...nel.org>,
SeongJae Park <sj@...nel.org>,
Jakub Kicinski <kuba@...nel.org>,
linux-arm-kernel@...ts.infradead.org,
linux-riscv@...ts.infradead.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 5/5] arch_topology: Build cacheinfo from primary CPU
Hi Pierre,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on driver-core/driver-core-testing]
[also build test WARNING on driver-core/driver-core-next driver-core/driver-core-linus arm64/for-next/core rafael-pm/linux-next linus/master v6.1-rc4 next-20221108]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Pierre-Gondois/arch_topology-Build-cacheinfo-from-primary-CPU/20221108-190738
patch link: https://lore.kernel.org/r/20221108110424.166896-6-pierre.gondois%40arm.com
patch subject: [PATCH 5/5] arch_topology: Build cacheinfo from primary CPU
config: ia64-randconfig-r024-20221108
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/1d2759f5c9fe043ae00116c153312eb6de3f4748
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Pierre-Gondois/arch_topology-Build-cacheinfo-from-primary-CPU/20221108-190738
git checkout 1d2759f5c9fe043ae00116c153312eb6de3f4748
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/base/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
drivers/base/cacheinfo.c: In function 'allocate_cache_info':
>> drivers/base/cacheinfo.c:404:50: warning: 'levels' is used uninitialized [-Wuninitialized]
404 | this_cpu_ci->num_leaves = levels + split_levels;
| ~~~~~~~^~~~~~~~~~~~~~
drivers/base/cacheinfo.c:389:22: note: 'levels' was declared here
389 | unsigned int levels, split_levels;
| ^~~~~~
>> drivers/base/cacheinfo.c:404:50: warning: 'split_levels' is used uninitialized [-Wuninitialized]
404 | this_cpu_ci->num_leaves = levels + split_levels;
| ~~~~~~~^~~~~~~~~~~~~~
drivers/base/cacheinfo.c:389:30: note: 'split_levels' was declared here
389 | unsigned int levels, split_levels;
| ^~~~~~~~~~~~
vim +/levels +404 drivers/base/cacheinfo.c
385
386 int allocate_cache_info(unsigned int cpu)
387 {
388 struct cpu_cacheinfo *this_cpu_ci;
389 unsigned int levels, split_levels;
390 int ret;
391
392 if (acpi_disabled)
393 ret = init_of_cache_level(cpu);
394 else {
395 ret = acpi_get_cache_info(cpu, &levels, &split_levels);
396 this_cpu_ci = get_cpu_cacheinfo(cpu);
397 this_cpu_ci->num_levels = levels;
398 /*
399 * This assumes that:
400 * - there cannot be any split caches (data/instruction)
401 * above a unified cache
402 * - data/instruction caches come by pair
403 */
> 404 this_cpu_ci->num_leaves = levels + split_levels;
405 }
406 if (ret < 0)
407 return ret;
408 else if (!cache_leaves(cpu))
409 return -ENOENT;
410
411 per_cpu_cacheinfo(cpu) = kcalloc(cache_leaves(cpu),
412 sizeof(struct cacheinfo), GFP_ATOMIC);
413 if (per_cpu_cacheinfo(cpu) == NULL) {
414 cache_leaves(cpu) = 0;
415 return -ENOMEM;
416 }
417
418 return ret;
419 }
420
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (158171 bytes)
Powered by blists - more mailing lists