[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7e507c3a4832d12471a24b75033bd1e742151f03.camel@mediatek.com>
Date: Tue, 6 Dec 2022 09:05:05 +0000
From: Xiangsheng Hou (侯祥胜)
<Xiangsheng.Hou@...iatek.com>
To: "miquel.raynal@...tlin.com" <miquel.raynal@...tlin.com>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
"broonie@...nel.org" <broonie@...nel.org>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
"gch981213@...il.com" <gch981213@...il.com>,
"vigneshr@...com" <vigneshr@...com>,
"richard@....at" <richard@....at>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>,
"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Benliang Zhao (赵本亮)
<Benliang.Zhao@...iatek.com>,
"linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
Bin Zhang (章斌) <bin.zhang@...iatek.com>
Subject: Re: [PATCH v2 8/9] dt-bindings: mtd: Split ECC engine with rawnand
controller
Hi Krzysztof,
On Mon, 2022-12-05 at 10:21 +0100, Krzysztof Kozlowski wrote:
> On 05/12/2022 07:57, Xiangsheng Hou wrote:
> > 1. Split MediaTek ECC engine with rawnand controller and convert to
> > YAML schema.
> > 2. Change the existing node name in order to match NAND controller
> > DT
> > bindings.
>
> One patch - one logical change. Not two. This applies to all your
> patches, so whenever you want to enumerate, please think twice.
Will be corrected in next series.
>
> >
> > Signed-off-by: Xiangsheng Hou <xiangsheng.hou@...iatek.com>
> > ---
> > .../bindings/mtd/mediatek,mtk-nfc.yaml | 171
> > +++++++++++++++++
> > .../mtd/mediatek,nand-ecc-engine.yaml | 62 ++++++
> > .../devicetree/bindings/mtd/mtk-nand.txt | 176 --------------
> > ----
> > arch/arm/boot/dts/mt2701.dtsi | 2 +-
> > arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 2 +-
> > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 +-
>
> Do not combine bindings and DTS.
The DTS modification will be separated.
> >
> > +
> > + ecc-engine: true
>
> I don't think this could be anything. You need to describe it, so
> $ref
> and description.
Will do.
> > +
> > + partitions:
> > + $ref: mtd.yaml#
>
> How the partitions are MTD device? Open that file and see how it
> should
> be defined... Anyway mtd.yaml is part of nand-chip, not nand-
> controller.
This will be dropped in next series since nand-chip is part of nand-
controller.
> > +
> > +allOf:
> > + - $ref: nand-controller.yaml#
> > +
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: mediatek,mt2701-nfc
> > + then:
> > + patternProperties:
> > + "^nand@[a-f0-9]$":
> > + type: object
>
> No need for type, the definition is already there through
> nand-controller.yaml.
>
> > + properties:
> > + reg:
> > + minimum: 0
> > + maximum: 1
>
> This is the same as other variant, so should be defined in top-level
> pattern properties.
>
> > + nand-ecc-mode:
> > + const: hw
>
> Ditto
Will be fixed in next series.
Thanks
Xiangsheng Hou
Powered by blists - more mailing lists