[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y5HYBzZlkTrsdjfX@smile.fi.intel.com>
Date: Thu, 8 Dec 2022 14:26:47 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Wolfram Sang <wsa@...nel.org>,
Luca Ceresoli <luca.ceresoli@...tlin.com>,
Matti Vaittinen <Matti.Vaittinen@...rohmeurope.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Peter Rosin <peda@...ntia.se>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
Michael Tretter <m.tretter@...gutronix.de>,
Shawn Tu <shawnx.tu@...el.com>,
Hans Verkuil <hverkuil@...all.nl>,
Mike Pagano <mpagano@...too.org>,
Krzysztof HaĆasa <khalasa@...p.pl>,
Marek Vasut <marex@...x.de>
Subject: Re: [PATCH v5 0/8] i2c-atr and FPDLink
On Thu, Dec 08, 2022 at 12:42:13PM +0200, Tomi Valkeinen wrote:
> On 08/12/2022 12:39, Tomi Valkeinen wrote:
...
> +#include <linux/fwnode.h>
> #include <linux/i2c-atr.h>
> #include <linux/i2c.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/mutex.h>
> -#include <linux/of.h>
> #include <linux/slab.h>
+ Blank line here?
> +#define ATR_MAX_ADAPTERS 99 /* Just a sanity limit */
> +#define ATR_MAX_SYMLINK_LEN 16 /* Longest name is 10 chars: "channel-99" */
...
> + u16 *new_buf;
> +
> + new_buf = kmalloc_array(num, sizeof(chan->orig_addrs[0]),
> + GFP_KERNEL);
new_buf = kmalloc_array(num, sizeof(*new_buf), GFP_KERNEL);
?
> + if (!new_buf)
> return -ENOMEM;
...
> struct i2c_atr_cli2alias_pair *c2a;
> - u16 alias_id = 0;
> - int ret = 0;
> + u16 alias_id;
> + int ret;
Is it mangled or it's missing blank line here?
> c2a = kzalloc(sizeof(*c2a), GFP_KERNEL);
> if (!c2a)
...
> struct device;
> struct i2c_atr;
> +struct fwnode_handle;
Order?
...
> /**
> - * Helper to add I2C ATR features to a device driver.
> + * struct i2c_atr - Represents the I2C ATR instance
> */
This is incomplete. Have you run kernel doc validator against this file?
> struct i2c_atr {
> };
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists