[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y5HY4/Ho48KrGFoR@smile.fi.intel.com>
Date: Thu, 8 Dec 2022 14:30:27 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Wolfram Sang <wsa@...nel.org>,
Luca Ceresoli <luca.ceresoli@...tlin.com>,
Matti Vaittinen <Matti.Vaittinen@...rohmeurope.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Peter Rosin <peda@...ntia.se>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
Michael Tretter <m.tretter@...gutronix.de>,
Shawn Tu <shawnx.tu@...el.com>,
Hans Verkuil <hverkuil@...all.nl>,
Mike Pagano <mpagano@...too.org>,
Krzysztof HaĆasa <khalasa@...p.pl>,
Marek Vasut <marex@...x.de>,
Luca Ceresoli <luca@...aceresoli.net>
Subject: Re: [PATCH v5 1/8] i2c: core: let adapters be notified of client
attach/detach
On Thu, Dec 08, 2022 at 12:39:59PM +0200, Tomi Valkeinen wrote:
> From: Luca Ceresoli <luca@...aceresoli.net>
>
> An adapter might need to know when a new device is about to be
> added. This will soon bee needed to implement an "I2C address
> translator" (ATR for short), a device that propagates I2C transactions
> with a different slave address (an "alias" address). An ATR driver
> needs to know when a slave is being added to find a suitable alias and
> program the device translation map.
>
> Add an attach/detach callback pair to allow adapter drivers to be
> notified of clients being added and removed.
...
> + if (adap->attach_ops &&
> + adap->attach_ops->attach_client &&
> + adap->attach_ops->attach_client(adap, info, client) != 0)
> + goto out_remove_swnode;
With a temporary variable it becomes better
... *ops = adap->attach_ops;
if (ops && ops->attach_client && ops->attach_client(adap, info, client))
Also notice drop of unneeded ' != 0' part.
> status = device_register(&client->dev);
> if (status)
> - goto out_remove_swnode;
> + goto out_detach_client;
>
> dev_dbg(&adap->dev, "client [%s] registered with bus id %s\n",
> client->name, dev_name(&client->dev));
>
> return client;
>
> +out_detach_client:
> + if (adap->attach_ops && adap->attach_ops->detach_client)
> + adap->attach_ops->detach_client(adap, client);
In the similar way.
...
> + if (adap->attach_ops &&
> + adap->attach_ops->detach_client)
> + adap->attach_ops->detach_client(adap, client);
In the similar way.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists