linux-kernel - drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:33:18: sparse: sparse: symbol 'nvkm_engn_cgrp_get' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 15 Dec 2022 18:14:15 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ben Skeggs <bskeggs@...hat.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Lyude Paul <lyude@...hat.com>
Subject: drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:33:18: sparse:
 sparse: symbol 'nvkm_engn_cgrp_get' was not declared. Should it be static?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   041fae9c105ae342a4245cf1e0dc56a23fbb9d3c
commit: 4d60100a23ec5b98e43277d82e5de53c359cf02c drm/nouveau/fifo: add common channel recovery
date:   5 weeks ago
config: s390-randconfig-s052-20221214
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4d60100a23ec5b98e43277d82e5de53c359cf02c
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 4d60100a23ec5b98e43277d82e5de53c359cf02c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=s390 SHELL=/bin/bash drivers/gpu/drm/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:33:18: sparse: sparse: symbol 'nvkm_engn_cgrp_get' was not declared. Should it be static?
   drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:185:18: sparse: sparse: context imbalance in 'nvkm_runl_chan_get_inst' - wrong count at exit
   drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:209:18: sparse: sparse: context imbalance in 'nvkm_runl_chan_get_chid' - different lock contexts for basic block
   drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:230:18: sparse: sparse: context imbalance in 'nvkm_runl_cgrp_get_cgid' - different lock contexts for basic block

vim +/nvkm_engn_cgrp_get +33 drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c

    32	
  > 33	struct nvkm_cgrp *
    34	nvkm_engn_cgrp_get(struct nvkm_engn *engn, unsigned long *pirqflags)
    35	{
    36		struct nvkm_cgrp *cgrp = NULL;
    37		struct nvkm_chan *chan;
    38		bool cgid;
    39		int id;
    40	
    41		id = engn->func->cxid(engn, &cgid);
    42		if (id < 0)
    43			return NULL;
    44	
    45		if (!cgid) {
    46			chan = nvkm_runl_chan_get_chid(engn->runl, id, pirqflags);
    47			if (chan)
    48				cgrp = chan->cgrp;
    49		} else {
    50			cgrp = nvkm_runl_cgrp_get_cgid(engn->runl, id, pirqflags);
    51		}
    52	
    53		WARN_ON(!cgrp);
    54		return cgrp;
    55	}
    56	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (174595 bytes)