[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y6B3eAn3D7ifK8By@smile.fi.intel.com>
Date: Mon, 19 Dec 2022 16:38:48 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 01/17] pinctrl: intel: Introduce INTEL_COMMUNITY_*()
to unify community macros
On Mon, Dec 19, 2022 at 04:32:55PM +0200, Mika Westerberg wrote:
> On Mon, Dec 19, 2022 at 02:26:27PM +0200, Andy Shevchenko wrote:
> > Now it becomes visible that we can deduplicate SoC specific
> > *_COMMUNITY() macros across the Intel pin control drivers.
> > For that, introduce a common INTEL_COMMUNITY_GPPS() and
> > INTEL_COMMUNITY_SIZE() macros in the pinctrl-intel.h.
>
> You should really start learning how to use --cover-letter option with
> git format-patch because for anything more than one patch pretty much
> requires such.
Oh, indeed.
> Here I would really like to see how much lines this
> series ends up removing :)
drivers/pinctrl/intel/pinctrl-alderlake.c | 18 ++----------------
drivers/pinctrl/intel/pinctrl-broxton.c | 31 +++++++++++--------------------
drivers/pinctrl/intel/pinctrl-cannonlake.c | 31 +++++++++++--------------------
drivers/pinctrl/intel/pinctrl-cedarfork.c | 13 +------------
drivers/pinctrl/intel/pinctrl-denverton.c | 13 +------------
drivers/pinctrl/intel/pinctrl-elkhartlake.c | 24 +++++++-----------------
drivers/pinctrl/intel/pinctrl-emmitsburg.c | 13 +------------
drivers/pinctrl/intel/pinctrl-geminilake.c | 21 ++++++---------------
drivers/pinctrl/intel/pinctrl-icelake.c | 35 +++++++++++++----------------------
drivers/pinctrl/intel/pinctrl-intel.c | 9 +--------
drivers/pinctrl/intel/pinctrl-intel.h | 35 +++++++++++++++++++++++++++++------
drivers/pinctrl/intel/pinctrl-jasperlake.c | 13 +------------
drivers/pinctrl/intel/pinctrl-lakefield.c | 13 +------------
drivers/pinctrl/intel/pinctrl-lewisburg.c | 12 +-----------
drivers/pinctrl/intel/pinctrl-meteorlake.c | 23 ++++++-----------------
drivers/pinctrl/intel/pinctrl-sunrisepoint.c | 37 +++++++++++++------------------------
drivers/pinctrl/intel/pinctrl-tigerlake.c | 30 ++++++++++--------------------
17 files changed, 115 insertions(+), 256 deletions(-)
> The series looks good to me, though.
Thank you!
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists