linux-kernel - Re: [PATCH v2 0/3] can: esd_usb: Some more preparation for supporting esd CAN-USB/3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230215085227.sqpqtzprsmpzdthu@pengutronix.de>
Date:   Wed, 15 Feb 2023 09:52:27 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Frank Jungclaus <frank.jungclaus@....eu>
Cc:     linux-can@...r.kernel.org, Wolfgang Grandegger <wg@...ndegger.com>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>,
        Stefan Mätje <stefan.maetje@....eu>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] can: esd_usb: Some more preparation for
 supporting esd CAN-USB/3

On 14.02.2023 17:02:20, Frank Jungclaus wrote:
> Another small batch of patches to be seen as preparation for adding
> support of the newly available esd CAN-USB/3 to esd_usb.c.
> 
> Due to some unresolved questions adding support for
> CAN_CTRLMODE_BERR_REPORTING has been postponed to one of the future
> patches.
> 
> *Resend of the whole series as v2 for easier handling.*

As Vincent pointed out in review of a completely different patch series,
bu this applies here, too:

| For the titles, please use imperative (e.g. add) instead of past tense
| (e.g. Added). This also applies to the description.

Further, the subject ob patches 1 and 2 can be improved a bit, e.g.
patch 1 could mention to move the SJA1000_ECC_SEG for a specific reason.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)