linux-kernel - Re: [PATCH v1] perf test: Fix "PMU event table sanity" for NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eae0bd08-b18b-a9e2-ebc6-04c94534dfc3@oracle.com>
Date:   Wed, 8 Mar 2023 09:58:16 +0000
From:   John Garry <john.g.garry@...cle.com>
To:     Ian Rogers <irogers@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Kajol Jain <kjain@...ux.ibm.com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] perf test: Fix "PMU event table sanity" for
 NO_JEVENTS=1

On 08/03/2023 00:27, Ian Rogers wrote:
> A table was renamed and needed to be renamed in the empty case.
> 
> Fixes: 62774db2a05d ("perf jevents: Generate metrics and events as separate tables")

This looks ok, so:

Reviewed-by: John Garry <john.g.garry@...cle.com>

But a comment, below.

> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>   tools/perf/pmu-events/empty-pmu-events.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/pmu-events/empty-pmu-events.c b/tools/perf/pmu-events/empty-pmu-events.c
> index a938b74cf487..e74defb5284f 100644
> --- a/tools/perf/pmu-events/empty-pmu-events.c
> +++ b/tools/perf/pmu-events/empty-pmu-events.c
> @@ -227,7 +227,7 @@ static const struct pmu_events_map pmu_events_map[] = {
>   	},
>   };
>   
> -static const struct pmu_event pme_test_soc_sys[] = {
> +static const struct pmu_event pmu_events__test_soc_sys[] = {

Would it make sense or even possible to put these table names in macros 
in a common header?

Thanks,
John

>   	{
>   		.name = "sys_ddr_pmu.write_cycles",
>   		.event = "event=0x2b",
> @@ -258,8 +258,8 @@ struct pmu_sys_events {
>   
>   static const struct pmu_sys_events pmu_sys_event_tables[] = {
>   	{
> -		.table = { pme_test_soc_sys },
> -		.name = "pme_test_soc_sys",
> +		.table = { pmu_events__test_soc_sys },
> +		.name = "pmu_events__test_soc_sys",
>   	},
>   	{
>   		.table = { 0 }