lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <63c98c518c1e4bfbb36c5295ba7c959d@AcuMS.aculab.com> Date: Sun, 19 Mar 2023 22:28:12 +0000 From: David Laight <David.Laight@...LAB.COM> To: 'Matthew Wilcox' <willy@...radead.org>, Lorenzo Stoakes <lstoakes@...il.com> CC: "linux-mm@...ck.org" <linux-mm@...ck.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>, Andrew Morton <akpm@...ux-foundation.org>, Baoquan He <bhe@...hat.com>, Uladzislau Rezki <urezki@...il.com>, "David Hildenbrand" <david@...hat.com>, Liu Shixin <liushixin2@...wei.com>, "Jiri Olsa" <jolsa@...nel.org> Subject: RE: [PATCH 4/4] mm: vmalloc: convert vread() to vread_iter() From: Matthew Wilcox > Sent: 19 March 2023 02:51 > > On Sun, Mar 19, 2023 at 12:20:12AM +0000, Lorenzo Stoakes wrote: > > /* for /proc/kcore */ > > -extern long vread(char *buf, char *addr, unsigned long count); > > +extern long vread_iter(char *addr, size_t count, struct iov_iter *iter); > > I don't love the order of the arguments here. Usually we follow > memcpy() and have (dst, src, len). This sometimes gets a bit more > complex when either src or dst need two arguments, but that's not the > case here. And, if 'addr' is the source (which Matthew's comment implies) it ought to be 'const char *' (or probably even 'const void *'). David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
Powered by blists - more mailing lists