linux-kernel - Re: [PATCH v2 1/4] dt-bindings: mfd: Add TI TPS6594 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Mar 2023 11:48:06 +0100
From:   Julien Panis <jpanis@...libre.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh@...nel.org>
Cc:     lee@...nel.org, krzysztof.kozlowski+dt@...aro.org, corbet@....net,
        arnd@...db.de, gregkh@...uxfoundation.org,
        derek.kiernan@...inx.com, dragan.cvetic@...inx.com,
        eric.auger@...hat.com, jgg@...pe.ca, razor@...ckwall.org,
        stephen@...workplumber.org, davem@...emloft.net,
        christian.koenig@....com, contact@...rsion.fr,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, sterzik@...com, u-kumar1@...com,
        eblanc@...libre.com, jneanne@...libre.com
Subject: Re: [PATCH v2 1/4] dt-bindings: mfd: Add TI TPS6594 PMIC



On 3/21/23 11:32, Krzysztof Kozlowski wrote:
> On 21/03/2023 10:03, Julien Panis wrote:
>>
>> On 3/21/23 08:36, Krzysztof Kozlowski wrote:
>>> On 20/03/2023 17:35, Julien Panis wrote:
>>>> On 3/20/23 16:53, Rob Herring wrote:
>>>>> On Wed, Mar 15, 2023 at 12:07:33PM +0100, Julien Panis wrote:
>>>>>> TPS6594 is a Power Management IC which provides regulators and others
>>>>>> features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and
>>>>>> PFSM (Pre-configurable Finite State Machine) managing the state of the
>>>>>> device.
>>>>>> TPS6594 is the super-set device while TPS6593 and LP8764X are derivatives.
>>>>> As mentioned, the binding needs to be complete. It's missing GPIO at
>>>>> least. RTC and watchdog may or may not need binding changes.
>>>> Thank you for your feedback.
>>>>
>>>> About GPIO, do you speak about 'gpio-controller'
>>>> and/or '#gpio-cells' properties ?
>>> Yes.
>>>
>>>> For RTC (and for watchdog, once the driver will be
>>>> implemented), our driver do not require any node
>>>> to work. What could make an explicit instantiation
>>>> necessary in DT ?
>>> Properties from RTC schema, e.g. start-year, wakeup etc.
>> TPS6594 RTC driver is being reviewed (this is another patch
>> series, not merged yet). These properties are not used by our
>> driver, that's why we did not have to add some RTC node in
>> the DT (until now, using such properties in our driver was not
>> requested by RTC sub-system maintainers).
> Bindings should be complete, regardless whether you now need this in
> driver or not. Does your comment mean that you will never need these,
> because hardware does not support them, and never going to add?
> Otherwise I don't get why you refer to driver when we talk about bindings...

OK, I understand now (I misinterpreted "RTC and watchdog may or may not
need binding changes").

> Best regards,
> Krzysztof
>