linux-kernel - Re: [PATCH v2] mm: oom: introduce cpuset oom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36b96b9c-d08a-e97c-05ff-152d671880e6@redhat.com>
Date:   Thu, 6 Apr 2023 11:53:27 -0400
From:   Waiman Long <longman@...hat.com>
To:     Gang Li <ligang.bdlg@...edance.com>
Cc:     rientjes@...gle.com, linux-kernel@...r.kernel.org,
        Zefan Li <lizefan.x@...edance.com>, cgroups@...r.kernel.org
Subject: Re: [PATCH v2] mm: oom: introduce cpuset oom


On 4/6/23 09:02, Gang Li wrote:
> On 2023/4/5 01:24, Waiman Long wrote:
>>
>> You will also need to take cpuset_rwsem to make sure that cpusets are 
>> stable. BTW, the cpuset_cgroup_scan_tasks() name is kind of 
>> redundant. I will suggest you just name it as cpuset_scan_tasks(). 
>> Please also add a 
>
> mem cgroup oom use `mem_cgroup_scan_tasks`.
> How about keep `cpuset_cgroup_scan_tasks` for naming consistency?

The "memory cgroup" term is used to identify the code related to memory 
cgroup controller. Cpuset, on the other hand, is a well known cgroup 
controller. Cpuset cgroup is not a term that people will normally use.  
That is why this name is awkward.

Cheers,
Longman