linux-kernel - Re: (2) [PATCH 2/2] nvme-pci: fix metadata mapping length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq13554bm4l.fsf@ca-mkp.ca.oracle.com>
Date:   Wed, 12 Apr 2023 21:37:04 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Jinyoung CHOI <j-young.choi@...sung.com>
Cc:     "hch@....de" <hch@....de>, "kbusch@...nel.org" <kbusch@...nel.org>,
        "axboe@...com" <axboe@...com>,
        "sagi@...mberg.me" <sagi@...mberg.me>,
        "chaitanya.kulkarni@....com" <chaitanya.kulkarni@....com>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
Subject: Re: (2) [PATCH 2/2] nvme-pci: fix metadata mapping length


Jinyoung,

> I think the problem is bio_integrity_add_page().  If it is modified,
> sg functions for blk-integrity should also be modified.

The bio integrity scatterlist handling predates NVMe and wasn't written
with the single segment use case in mind. For SCSI we required the
hardware to support an integrity segment per data segment.

-- 
Martin K. Petersen	Oracle Linux Engineering