linux-kernel - Re: [PATCH v1 1/4] dt-bindings: thermal: tsens: Add ipq9574 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 May 2023 12:30:27 +0530
From:   Varadarajan Narayanan <quic_varada@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC:     <amitk@...nel.org>, <thara.gopinath@...il.com>,
        <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <rafael@...nel.org>,
        <daniel.lezcano@...aro.org>, <rui.zhang@...el.com>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <linux-pm@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Praveenkumar I <quic_ipkumar@...cinc.com>
Subject: Re: [PATCH v1 1/4] dt-bindings: thermal: tsens: Add ipq9574
 compatible

On Wed, May 03, 2023 at 08:34:45AM +0200, Krzysztof Kozlowski wrote:
> On 03/05/2023 06:45, Varadarajan Narayanan wrote:
> > From: Praveenkumar I <quic_ipkumar@...cinc.com>
> >
> > Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens.
> >
> > Signed-off-by: Praveenkumar I <quic_ipkumar@...cinc.com>
> > Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> > ---
> >  Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> >
>
> I saw already v1, so this looks like v2, not v1. Please add changelog
> describing what you changed here.

No code change between v1 and v2 w.r.t this patch. The 4th patch
alone in this series has code changes between v1 and v2.

> > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> > index d1ec963..8e2208c 100644
> > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> > @@ -66,6 +66,7 @@ properties:
> >        - description: v2 of TSENS with combined interrupt
> >          enum:
> >            - qcom,ipq8074-tsens
> > +          - qcom,ipq9574-tsens
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
> Thank you.

Sorry. Looks like I missed https://lore.kernel.org/lkml/20230502080611.GB26126@varda-linux.qualcomm.com/T/#m42a9b77be2ceddf1adc90c07f487929fcf2dbc0f
Will take that input and post a new version.

Thanks
Varada

> Best regards,
> Krzysztof
>