linux-kernel - Re: [PATCH] mips: dts: ralink: Clarify usage of MT7621 ethernet phy arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5fdd37e-6f42-2f37-357f-ad5bb082fa7d@arinc9.com>
Date:   Wed, 10 May 2023 14:59:44 +0200
From:   Arınç ÜNAL <arinc.unal@...nc9.com>
To:     Liviu Dudau <liviu@...au.co.uk>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Paul Burton <paulburton@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Sergio Paracuellos <sergio.paracuellos@...il.com>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] mips: dts: ralink: Clarify usage of MT7621 ethernet phy
 arguments

On 9.05.2023 22:00, Liviu Dudau wrote:
> The device tree uses numbers as arguments to the phys property that are
> confusing for newcomers. Define names for the values and use them in the
> device tree.
> 
> Signed-off-by: Liviu Dudau <liviu@...au.co.uk>

You should document this on 
Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml instead 
of doing this. Under the phys property, add 'description:' and explain this.

Arınç