linux-kernel - Re: [PATCH v4 2/3] dt-bindings: arm: fsl: Enumerate Emtop SOM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <538a009b-d5b5-da72-f775-9ec89b34afda@linaro.org>
Date:   Wed, 10 May 2023 15:01:42 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Marek Vasut <marex@...x.de>,
        Frieder Schrempf <frieder.schrempf@...tron.de>,
        Stefan Wahren <stefan.wahren@...e.com>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Markus Niebel <Markus.Niebel@...group.com>,
        Heiko Stuebner <heiko@...ech.de>,
        Bjorn Andersson <andersson@...nel.org>,
        Chris Morgan <macromorgan@...mail.com>,
        Jagan Teki <jagan@...eble.ai>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Li Yang <leoyang.li@....com>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 2/3] dt-bindings: arm: fsl: Enumerate Emtop SOM

On 10/05/2023 13:23, Himanshu Bhavani wrote:
> Add entries to the list of imx8mm boards denoting
> the Emtop SOM from Emtop.
> 
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 442ce8f4d675..06eb2c790f90 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -884,6 +884,7 @@ properties:
>                - beacon,imx8mm-beacon-kit  # i.MX8MM Beacon Development Kit
>                - boundary,imx8mm-nitrogen8mm  # i.MX8MM Nitrogen Board
>                - dmo,imx8mm-data-modul-edm-sbc # i.MX8MM eDM SBC
> +              - emtop,imx8mm-emtop          # i.MX8MM Emtop SOM-IMX8MMLPD4 SoM

No real improvements. Still not change in compatible - neither naming
nor additional compatible.

Instead of adding some random changes, please describe in commit msg
what is this exactly and then use compatibles matching it.

You already got two times the same comment that board called "emtop" so
the same as vendor "emtop" looks wrong. You never responded to these
comments. Don't ignore feedbacks, but either respond or implement them.

Best regards,
Krzysztof